Filler task dropped, login results in task assoc

MSP-10683

* Task constraint now optional, so no need for filler
* Task ID now in service_data so it's passed to the core and the login
creation methods

Author: shuckins-r7

lib/msf/core/db.rb

@@ -3452,11 +3452,7 @@ def inspect_single_packet_http(pkt,wspace,args)
             protocol: 'tcp',
             workspace_id: wspace.id
         }
-
-        if task.nil?
-          task = wspace.tasks.create
-        end
-        task_id = task.id
+        service_data[:task_id] = task.id if task
 
         filename = args[:filename]
 
@@ -3465,7 +3461,6 @@ def inspect_single_packet_http(pkt,wspace,args)
             private_data: pass,
             private_type: :password,
             username: user,
-            task_id: task_id,
             filename: filename
         }
         credential_data.merge!(service_data)