Land rapid7#5395, fixes rapid7#5378, corrects search -S

Author: HD Moore

lib/msf/ui/console/command_dispatcher/db.rb

@@ -1270,8 +1270,8 @@ def cmd_notes(*args)
       end
     end
     if search_term
-      note_list.delete_if do |n|
-        !n.attribute_names.any? { |a| n[a.intern].to_s.match(search_term) }
+      note_list = note_list.select do |n|
+        n.attribute_names.any? { |a| n[a.intern].to_s.match(search_term) }
       end
     end