Use be_truthy instead of be_true

Author: jvazquez-r7

spec/lib/active_record/connection_adapters/abstract_adapter/connection_pool_spec.rb

@@ -44,7 +44,7 @@ def database_configurations_pathname
     end
 
     context 'in thread with connection' do
-      it { should be_true }
+      it { should be_truthy }
     end
 
     context 'in thread without connection' do
@@ -97,7 +97,7 @@ def reserved_connection_count
       end
 
       it 'should return true from #active_connection?' do
-        expect(connection_pool.active_connection?).to be_true
+        expect(connection_pool.active_connection?).to be_truthy
       end
 
       context 'with error' do

spec/lib/fastlib_spec.rb

@@ -73,7 +73,7 @@
 
           described_class.dump(@destination_path, flag_string, base_path, *unarchived_paths)
 
-          File.exist?(@destination_path).should be_true
+          File.exist?(@destination_path).should be_truthy
         end
 
         context 'cache' do
@@ -114,7 +114,7 @@
 
               # make sure that the unarchived module exists and hasn't be deleted or renamed before expecting it to be
               # in the archive.
-              File.exist?(unarchived_path).should be_true
+              File.exist?(unarchived_path).should be_truthy
               cache[archived_path].should_not be_nil
             end
           end
@@ -131,7 +131,7 @@
 
           described_class.dump(@destination_path, flag_string, base_path, *unarchived_paths)
 
-          File.exist?(@destination_path).should be_true
+          File.exist?(@destination_path).should be_truthy
         end
 
         it 'should be smaller than the uncompressed archive' do
@@ -144,8 +144,8 @@
           described_class.dump(uncompressed_path, '', base_path, *unarchived_paths)
           described_class.dump(compressed_path, flag_string, base_path, *unarchived_paths)
 
-          File.exist?(uncompressed_path).should be_true
-          File.exist?(compressed_path).should be_true
+          File.exist?(uncompressed_path).should be_truthy
+          File.exist?(compressed_path).should be_truthy
 
           File.size(compressed_path).should < File.size(uncompressed_path)
         end
@@ -161,7 +161,7 @@
 
           described_class.dump(@destination_path, flag_string, base_path, *unarchived_paths)
 
-          File.exist?(@destination_path).should be_true
+          File.exist?(@destination_path).should be_truthy
         end
       end
 
@@ -175,7 +175,7 @@
 
           described_class.dump(@destination_path, flag_string, base_path, *unarchived_paths)
 
-          File.exist?(@destination_path).should be_true
+          File.exist?(@destination_path).should be_truthy
         end
       end
     end
@@ -194,7 +194,7 @@
       # ensure modules expected to be listed actually exist
       it 'should use existent unarchived modules' do
         unarchived_paths.each do |unarchived_path|
-          File.exist?(unarchived_path).should be_true
+          File.exist?(unarchived_path).should be_truthy
         end
       end
 

spec/lib/metasploit/framework/credential_spec.rb

@@ -22,7 +22,7 @@
 
   describe "#paired" do
     it "defaults to true" do
-      expect(cred_detail.paired).to be_true
+      expect(cred_detail.paired).to be_truthy
     end
   end
 

spec/lib/metasploit/framework/login_scanner/result_spec.rb

@@ -29,14 +29,14 @@
   context '#success?' do
     context 'when the status code is success' do
         it 'returns true' do
-          expect(login_result.success?).to be_true
+          expect(login_result.success?).to be_truthy
         end
     end
 
     context 'when the status code is anything else' do
       let(:status) { :connection_error }
       it 'returns false' do
-        expect(login_result.success?).to be_false
+        expect(login_result.success?).to be_truthy
       end
     end
   end

spec/lib/msf/core/exploit/cmdstager_spec.rb

@@ -332,7 +332,7 @@ def create_exploit(info ={})
       end
 
       it "is compatible" do
-        expect(subject.compatible_flavor?(flavor)).to be_true
+        expect(subject.compatible_flavor?(flavor)).to be_truthy
       end
     end
 
@@ -348,7 +348,7 @@ def create_exploit(info ={})
         end
 
         it "is compatible" do
-          expect(subject.compatible_flavor?(flavor)).to be_true
+          expect(subject.compatible_flavor?(flavor)).to be_truthy
         end
       end
 
@@ -375,7 +375,7 @@ def create_exploit(info ={})
         end
 
         it "is compatible" do
-          expect(subject.compatible_flavor?(flavor)).to be_true
+          expect(subject.compatible_flavor?(flavor)).to be_truthy
         end
       end
 
@@ -402,7 +402,7 @@ def create_exploit(info ={})
         end
 
         it "is compatible" do
-          expect(subject.compatible_flavor?(flavor)).to be_true
+          expect(subject.compatible_flavor?(flavor)).to be_truthy
         end
       end
 

spec/lib/msf/core/exploit/powershell_spec.rb

@@ -43,13 +43,13 @@ def decompress(code)
         script = File.read(example_script)
         compressed = subject.compress_script(script)
         compressed.length.should be < script.length
-        compressed.include?('IO.Compression').should be_true
+        compressed.include?('IO.Compression').should be_truthy
       end
 
       it 'should create a compressed script with eof' do
         script = File.read(example_script)
         compressed = subject.compress_script(script, 'end_of_file')
-        compressed.include?('end_of_file').should be_true
+        compressed.include?('end_of_file').should be_truthy
       end
     end
 
@@ -120,7 +120,7 @@ def decompress(code)
       it 'shouldnt substitute variables' do
         script = File.read(example_script)
         compressed = subject.compress_script(script)
-        decompress(compressed).include?('$hashes').should be_true
+        decompress(compressed).include?('$hashes').should be_truthy
       end
     end
 
@@ -144,7 +144,7 @@ def decompress(code)
       it 'shouldnt substitute variables' do
         script = File.read(example_script)
         compressed = subject.compress_script(script)
-        decompress(compressed).include?('DumpHashes').should be_true
+        decompress(compressed).include?('DumpHashes').should be_truthy
       end
     end
   end
@@ -159,28 +159,28 @@ def decompress(code)
     context 'when x86 payload' do
       it 'should generate code' do
         code = subject.run_hidden_psh(payload, arch, encoded)
-        code.include?('syswow64').should be_true
+        code.include?('syswow64').should be_truthy
       end
     end
 
     context 'when x64 payload' do
       it 'should generate code'  do
         code = subject.run_hidden_psh(payload, 'x86_64', encoded)
-        code.include?('sysnative').should be_true
+        code.include?('sysnative').should be_truthy
       end
     end
 
     context 'when encoded' do
       it 'should generate a code including an encoded command' do
         code = subject.run_hidden_psh(payload, arch, true)
-        code.include?('-nop -w hidden -e ').should be_true
+        code.include?('-nop -w hidden -e ').should be_truthy
       end
     end
 
     context 'when command' do
       it 'should generate code including a -c command' do
         code = subject.run_hidden_psh(payload, arch, encoded)
-        code.include?('-nop -w hidden -c ').should be_true
+        code.include?('-nop -w hidden -c ').should be_truthy
       end
     end
 
@@ -191,7 +191,7 @@ def decompress(code)
       end
       it 'should generate a code including unshorted args' do
         code = subject.run_hidden_psh(payload, arch, encoded)
-        code.include?('-NoProfile -WindowStyle hidden -NoExit -Command ').should be_true
+        code.include?('-NoProfile -WindowStyle hidden -NoExit -Command ').should be_truthy
       end
     end
   end
@@ -206,7 +206,7 @@ def decompress(code)
           except = true
         end
 
-        except.should be_true
+        except.should be_truthy
       end
     end
 
@@ -217,7 +217,7 @@ def decompress(code)
       end
       it 'should add a persistance loop' do
         code = subject.cmd_psh_payload(payload, arch)
-        decompress(code).include?('while(1){Start-Sleep -s ').should be_true
+        decompress(code).include?('while(1){Start-Sleep -s ').should be_truthy
       end
     end
 
@@ -239,7 +239,7 @@ def decompress(code)
       end
       it 'should prepend sleep' do
         code = subject.cmd_psh_payload(payload, arch)
-        decompress(code).include?('Start-Sleep -s ').should be_true
+        decompress(code).include?('Start-Sleep -s ').should be_truthy
       end
     end
 
@@ -272,15 +272,15 @@ def decompress(code)
       end
       it 'should generate a command line' do
         code = subject.cmd_psh_payload(payload, arch)
-        decompress(code).include?('-namespace Win32Functions').should be_true
+        decompress(code).include?('-namespace Win32Functions').should be_truthy
       end
       it 'shouldnt shorten args' do
         code = subject.cmd_psh_payload(payload, arch)
-        code.include?('-NoProfile -WindowStyle hidden -Command').should be_true
+        code.include?('-NoProfile -WindowStyle hidden -Command').should be_truthy
       end
       it 'should include -NoExit' do
         code = subject.cmd_psh_payload(payload, arch)
-        code.include?('-NoProfile -WindowStyle hidden -NoExit -Command').should be_true
+        code.include?('-NoProfile -WindowStyle hidden -NoExit -Command').should be_truthy
       end
     end
 
@@ -291,7 +291,7 @@ def decompress(code)
       end
       it 'should generate a command line' do
         code = subject.cmd_psh_payload(payload, arch)
-        decompress(code).include?('System.Runtime.InteropServices;').should be_true
+        decompress(code).include?('System.Runtime.InteropServices;').should be_truthy
       end
     end
 
@@ -302,7 +302,7 @@ def decompress(code)
       end
       it 'should generate a command line' do
         code = subject.cmd_psh_payload(payload, arch)
-        decompress(code).include?('GlobalAssemblyCache').should be_true
+        decompress(code).include?('GlobalAssemblyCache').should be_truthy
       end
     end
 
@@ -318,7 +318,7 @@ def decompress(code)
         rescue RuntimeError
           except = true
         end
-        except.should be_true
+        except.should be_truthy
       end
     end
 
@@ -333,7 +333,7 @@ def decompress(code)
         rescue RuntimeError
           except = true
         end
-        except.should be_true
+        except.should be_truthy
       end
       after do
         subject.datastore['Powershell::method'] = 'reflection'
@@ -344,7 +344,7 @@ def decompress(code)
     context 'when encode_inner_payload' do
       it 'should contain an inner payload with -e' do
           code = subject.cmd_psh_payload(payload, arch, {:encode_inner_payload => true})
-          code.include?(' -e ').should be_true
+          code.include?(' -e ').should be_truthy
       end
 
       context 'when no_equals is true' do
@@ -355,7 +355,7 @@ def decompress(code)
           rescue RuntimeError
             except = true
           end
-          except.should be_true
+          except.should be_truthy
         end
       end
     end
@@ -364,14 +364,14 @@ def decompress(code)
       context 'when no_equals is false' do
         it 'should contain a final payload with -e' do
           code = subject.cmd_psh_payload(payload, arch, {:encode_final_payload => true, :no_equals => false})
-          code.include?(' -e ').should be_true
+          code.include?(' -e ').should be_truthy
           code.include?(' -c ').should be_false
         end
       end
       context 'when no_equals is true' do
         it 'should contain a final payload with -e' do
           code = subject.cmd_psh_payload(payload, arch, {:encode_final_payload => true, :no_equals => true})
-          code.include?(' -e ').should be_true
+          code.include?(' -e ').should be_truthy
           code.include?(' -c ').should be_false
           code.include?('=').should be_false
         end
@@ -384,7 +384,7 @@ def decompress(code)
           rescue RuntimeError
             except = true
           end
-          except.should be_true
+          except.should be_truthy
         end
       end
     end
@@ -399,7 +399,7 @@ def decompress(code)
     context 'when use single quotes' do
       it 'should wrap in single quotes' do
         code = subject.cmd_psh_payload(payload, arch, {:use_single_quotes => true})
-        code.include?(' -c \'').should be_true
+        code.include?(' -c \'').should be_truthy
       end
     end
   end
@@ -408,27 +408,27 @@ def decompress(code)
     it 'should contain no full stop when :no_full_stop' do
       opts = {:no_full_stop => true}
       command = subject.generate_psh_command_line(opts)
-      command.include?("powershell ").should be_true
+      command.include?("powershell ").should be_truthy
     end
 
     it 'should contain full stop unless :no_full_stop' do
       opts = {}
       command = subject.generate_psh_command_line(opts)
-      command.include?("powershell.exe ").should be_true
+      command.include?("powershell.exe ").should be_truthy
 
       opts = {:no_full_stop => false}
       command = subject.generate_psh_command_line(opts)
-      command.include?("powershell.exe ").should be_true
+      command.include?("powershell.exe ").should be_truthy
     end
 
     it 'should ensure the path should always ends with \\' do
       opts = {:path => "test"}
       command = subject.generate_psh_command_line(opts)
-      command.include?("test\\powershell.exe ").should be_true
+      command.include?("test\\powershell.exe ").should be_truthy
 
       opts = {:path => "test\\"}
       command = subject.generate_psh_command_line(opts)
-      command.include?("test\\powershell.exe ").should be_true
+      command.include?("test\\powershell.exe ").should be_truthy
     end
   end