Skip to content

Commit 6b262cb

Browse files
author
Tod Beardsley
committed
Remove rubocop and msftidy touchpoints
This replicates PR rapid7#3639 for the staging/electro-release branch Rubocop replaces the default YAML library which makes development testing difficult. It does not cause problems on Travis, but according to reports, it does cause instability with many individual dev environments. While I would love to have a more solid source of this bug report, right now this was an oral report from @shuckins-r7 (who I tend to believe a lot). (Conflict resolved on rubocop.yml)
1 parent 1d430db commit 6b262cb

File tree

3 files changed

+0
-31
lines changed

3 files changed

+0
-31
lines changed

.rubocop.yml

Lines changed: 0 additions & 19 deletions
This file was deleted.

Gemfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ group :db do
1515
end
1616

1717
group :development do
18-
# Style/sanity checking Ruby code
19-
gem 'rubocop'
2018
# Markdown formatting for yard
2119
gem 'redcarpet'
2220
# generating documentation

tools/msftidy.rb

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -335,15 +335,6 @@ def check_extname
335335
end
336336
end
337337

338-
# Explicitly skip this check if we're suppressing info messages
339-
# anyway, since it takes a fair amount of time per module to perform.
340-
def check_rubocop
341-
return true if SUPPRESS_INFO_MESSAGES
342-
out = %x{rubocop -n #{@full_filepath}}
343-
ret = $?
344-
info("Fails to pass Rubocop Ruby style guidelines (run 'rubocop #{@full_filepath}' to see violations)") unless ret.exitstatus == 0
345-
end
346-
347338
def check_old_rubies
348339
return true unless CHECK_OLD_RUBIES
349340
return true unless Object.const_defined? :RVM
@@ -611,7 +602,6 @@ def run_checks(full_filepath)
611602
tidy.check_vuln_codes
612603
tidy.check_vars_get
613604
tidy.check_newline_eof
614-
tidy.check_rubocop
615605
tidy.check_sock_get
616606
tidy.check_udp_sock_get
617607
return tidy

0 commit comments

Comments
 (0)