Fix cache invalidation bug in tab completion

We use active_module instead of cmd_use to invalidate @cache_payloads,
since the ivar is no longer shared between cmd_set and cmd_use.

Fixes rapid7#8483. See rapid7#7655.

Author: wvu

lib/msf/ui/console/command_dispatcher/core.rb

@@ -139,10 +139,8 @@ def commands
   def initialize(driver)
     super
 
-    @dscache = {}
     @cache_payloads = nil
     @previous_module = nil
-    @module_name_stack = []
     @history_limit = 100
   end
 
@@ -2288,7 +2286,11 @@ def option_values_dispatch(o, str, words)
   # Provide valid payload options for the current exploit
   #
   def option_values_payloads
-    return @cache_payloads if @cache_payloads
+    if @cache_payloads && active_module == @previous_module
+      return @cache_payloads
+    else
+      @previous_module = active_module
+    end
 
     @cache_payloads = active_module.compatible_payloads.map { |refname, payload|
       refname

lib/msf/ui/console/command_dispatcher/modules.rb

@@ -48,7 +48,6 @@ def initialize(driver)
             super
 
             @dscache = {}
-            @cache_payloads = nil
             @previous_module = nil
             @module_name_stack = []
             @dangerzone_map = nil
@@ -645,7 +644,6 @@ def cmd_use(*args)
               active_module.datastore.update(@dscache[active_module.fullname])
             end
 
-            @cache_payloads = nil
             mod.init_ui(driver.input, driver.output)
 
             # Update the command prompt