Land rapid7#4738, msftidy falses, fixed

Author: Tod Beardsley

modules/auxiliary/scanner/lotus/lotus_domino_login.rb

@@ -54,7 +54,7 @@ def do_login(user=nil,pass=nil)
             :sname => (ssl ? "https" : "http"),
             :user   => user,
             :pass   => pass,
-            :proof  => "WEBAPP=\"Lotus Domino\", VHOST=#{vhost}, COOKIE=#{res.headers['Set-Cookie']}",
+            :proof  => "WEBAPP=\"Lotus Domino\", VHOST=#{vhost}, COOKIE=#{res.get_cookies}",
             :source_type => "user_supplied",
             :active => true
           )

tools/msftidy.rb

@@ -523,7 +523,7 @@ def check_lines
       end
 
       # The rest of these only count if it's not a comment line
-      next if ln =~ /[[:space:]]*#/
+      next if ln =~ /^[[:space:]]*#/
 
       if ln =~ /\$std(?:out|err)/i or ln =~ /[[:space:]]puts/
         next if ln =~ /^[\s]*["][^"]+\$std(?:out|err)/
@@ -538,7 +538,7 @@ def check_lines
       end
 
       # do not read Set-Cookie header (ignore commented lines)
-      if ln =~ /^(?!\s*#).+\[['"]Set-Cookie['"]\]/i
+      if ln =~ /^(?!\s*#).+\[['"]Set-Cookie['"]\](?!\s*=[^=~]+)/i
         warn("Do not read Set-Cookie header directly, use res.get_cookies instead: #{ln}", idx)
       end
 
@@ -547,7 +547,7 @@ def check_lines
         warn("Auxiliary modules have no 'Rank': #{ln}", idx)
       end
 
-      if ln =~ /^\s*def\s+(?:[^\(\)]*[A-Z]+[^\(\)]*)(?:\(.*\))?$/
+      if ln =~ /^\s*def\s+(?:[^\(\)#]*[A-Z]+[^\(\)]*)(?:\(.*\))?$/
         warn("Please use snake case on method names: #{ln}", idx)
       end
     end