Skip to content

Commit 6e9666c

Browse files
committed
Land rapid7#4231, more explicit instructs on commit msgs
Explicitly reminds people to be wary of default (merge) messages from Git when landing PRs on Metasploit.
2 parents 31184c6 + 0da756b commit 6e9666c

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

CONTRIBUTING.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,10 @@ and Metasploit's [Common Coding Mistakes](https://github.com/rapid7/metasploit-f
3737
## Code Contributions
3838

3939
* **Do** stick to the [Ruby style guide](https://github.com/bbatsov/ruby-style-guide).
40-
* *Do* get [Rubocop](https://rubygems.org/search?query=rubocop) relatively quiet against the code you are adding or modifying.
40+
* **Do** get [Rubocop](https://rubygems.org/search?query=rubocop) relatively quiet against the code you are adding or modifying.
4141
* **Do** follow the [50/72 rule](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html) for Git commit messages.
42+
* **Don't** use the default merge messages when merging from other
43+
branches.
4244
* **Do** create a [topic branch](http://git-scm.com/book/en/Git-Branching-Branching-Workflows#Topic-Branches) to work on instead of working directly on `master`.
4345

4446
### Pull Requests

0 commit comments

Comments
 (0)