Add more PAC constants

Author: jvazquez-r7

lib/msf/kerberos/client/pac.rb

@@ -42,11 +42,11 @@ def build_pa_pac_request(opts = {})
         # @see Rex::Proto::Kerberos::Pac::Type
         def build_pac(opts = {})
           user_name = opts[:client_name] || ''
-          user_id = opts[:user_id] || 1000
-          primary_group_id = opts[:group_id] || 513
-          group_ids = opts[:group_ids] || [513]
+          user_id = opts[:user_id] || Rex::Proto::Kerberos::Pac::DEFAULT_USER_SID
+          primary_group_id = opts[:group_id] || Rex::Proto::Kerberos::Pac::DOMAIN_USERS
+          group_ids = opts[:group_ids] || [Rex::Proto::Kerberos::Pac::DOMAIN_USERS]
           domain_name = opts[:realm] || ''
-          domain_id = opts[:domain_id] || 'S-1-1'
+          domain_id = opts[:domain_id] || Rex::Proto::Kerberos::Pac::NT_AUTHORITY_SID
           logon_time = opts[:logon_time] || Time.now
           checksum_type = opts[:checksum_type] || Rex::Proto::Kerberos::Crypto::RSA_MD5
 

lib/rex/proto/kerberos/pac.rb

@@ -6,25 +6,23 @@ module Kerberos
       module Pac
         VERSION = 0
         NETLOGON_FLAG = 0x20000
-
         SE_GROUP_MANDATORY = 1
         SE_GROUP_ENABLED_BY_DEFAULT = 2
         SE_GROUP_ENABLED = 4
         SE_GROUP_ALL = SE_GROUP_MANDATORY | SE_GROUP_ENABLED_BY_DEFAULT | SE_GROUP_ENABLED
-
         USER_NORMAL_ACCOUNT = 0x00000010
         USER_DONT_EXPIRE_PASSWORD = 0x00000200
-
         PAC_LOGON_INFO = 1
         PAC_SERVER_CHECKSUM = 6
         PAC_PRIVSVR_CHECKSUM = 7
         PAC_CLIENT_INFO = 10
-
         AD_WIN2K_PAC = 128
-
         SEC_TO_UNIX_EPOCH = 11644473600
         WINDOWS_TICK = 10000000
         NEVER_EXPIRE = 0x7fffffffffffffff
+        DOMAIN_USERS = 513
+        DEFAULT_USER_SID = 1000
+        NT_AUTHORITY_SID = 'S-1-5'
       end
     end
   end