Skip to content

Commit 77e76a8

Browse files
committed
Land rapid7#9419, grammar fixes for modules and docs
2 parents e5bd36d + 593813c commit 77e76a8

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

CONTRIBUTING.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ and Metasploit's [Common Coding Mistakes].
4545
* **Do** specify a descriptive title to make searching for your pull request easier.
4646
* **Do** include [console output], especially for witnessable effects in `msfconsole`.
4747
* **Do** list [verification steps] so your code is testable.
48-
* **Do** [reference associated issues] in your pull request description
49-
* **Do** write [release notes] once a pull request is landed
48+
* **Do** [reference associated issues] in your pull request description.
49+
* **Do** write [release notes] once a pull request is landed.
5050
* **Don't** leave your pull request description blank.
5151
* **Don't** abandon your pull request. Being responsive helps us land your code faster.
5252

@@ -58,8 +58,8 @@ Pull requests [PR#2940] and [PR#3043] are a couple good examples to follow.
5858
- It would be even better to set up `msftidy.rb` as a [pre-commit hook].
5959
* **Do** use the many module mixin [API]s. Wheel improvements are welcome; wheel reinventions, not so much.
6060
* **Don't** include more than one module per pull request.
61-
* **Do** include instructions on how to setup the vulnerable environment or software
62-
* **Do** include [Module Documentation](https://github.com/rapid7/metasploit-framework/wiki/Generating-Module-Documentation) showing sample run-throughs
61+
* **Do** include instructions on how to setup the vulnerable environment or software.
62+
* **Do** include [Module Documentation](https://github.com/rapid7/metasploit-framework/wiki/Generating-Module-Documentation) showing sample run-throughs.
6363

6464

6565

documentation/modules/exploit/windows/smb/ms08_067_netapi.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
ms08_067_netapi is one of the most popular remote exploits against Microsoft Windows. It is
2-
considered a reliable exploit, and allows you to gain access as SYSTEM - the highest Windows
3-
privilege. In modern day penetration test, this exploit would most likely be used in an internal
4-
environment, and not so much from external due to the likelihood of a firewall.
2+
considered a reliable exploit and allows you to gain access as SYSTEM - the highest Windows
3+
privilege. In modern day penetration tests, this exploit would most likely be used in an internal
4+
environment and not so much from external due to the likelihood of a firewall.
55

66
The check command of ms08_067_netapi is also highly accurate, because it is actually testing the
77
vulnerable code path, not just passively.
@@ -15,7 +15,7 @@ This exploit works against a vulnerable SMB service from one of these Windows sy
1515
* Windows XP
1616
* Windows 2003
1717

18-
To reliability determine whether the machine is vulnerable, you will have to either examine
18+
To reliably determine whether the machine is vulnerable, you will have to either examine
1919
the system's patch level, or use a vulnerability check.
2020

2121
## Verification Steps

documentation/modules/exploit/windows/smb/ms17_010_eternalblue.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
ms17_010_eternalblue is a remote exploit against Microsoft Windows, originally written by the
22
Equation Group (NSA) and leaked by Shadow Brokers (an unknown hacking entity). It is
3-
considered a reliable exploit, and allows you to gain access not only as SYSTEM - the highest Windows
4-
user mode privilege, but also full control of the kernel in ring 0. In modern day penetration test,
3+
considered a reliable exploit and allows you to gain access not only as SYSTEM - the highest Windows
4+
user mode privilege, but also full control of the kernel in ring 0. In modern day penetration tests,
55
this exploit can be found in internal and external environments.
66

77
As far as remote kernel exploits go, this one is highly reliable and safe to use.

0 commit comments

Comments
 (0)