Skip to content

Commit 7b386ea

Browse files
committed
Fix msftidy warnings wrt Set-Cookie
1 parent 85350a9 commit 7b386ea

File tree

2 files changed

+13
-12
lines changed

2 files changed

+13
-12
lines changed

modules/exploits/linux/http/epmp1000_get_chart_cmd_shell.rb

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -127,15 +127,15 @@ def login(user, pass)
127127
}
128128
)
129129

130+
cookies = res.get_cookies
130131
good_response = (
131132
res &&
132133
res.code == 200 &&
133-
res.headers.include?('Set-Cookie') &&
134-
res.headers['Set-Cookie'].include?('sysauth')
134+
cookies.include?('sysauth')
135135
)
136136

137137
if good_response
138-
sysauth_value = res.headers['Set-Cookie'].match(/((.*)[$ ])/)
138+
sysauth_value = cookies.match(/((.*)[$ ])/)
139139
cookie1 = "#{sysauth_value}"
140140
prevsessid = res.body.match(/((?:[a-z][a-z]*[0-9]+[a-z0-9]*))/)
141141

@@ -158,10 +158,11 @@ def login(user, pass)
158158
}
159159
)
160160

161+
cookies = res.get_cookies
161162
good_response = (
162163
res &&
163164
res.code == 200 &&
164-
res.headers.include?('Set-Cookie') &&
165+
!cookies.blank? &&
165166
!res.body.include?('auth_failed') &&
166167
!res.body.include?('Maximum number of users reached.')
167168
)
@@ -170,7 +171,7 @@ def login(user, pass)
170171
print_good("SUCCESSFUL LOGIN - #{rhost}:#{rport} - #{user.inspect}:#{pass.inspect}")
171172

172173
# get the cookie now
173-
sysauth_value_2 = res.headers['Set-Cookie'].match(/((.*)[$ ])/)
174+
sysauth_value_2 = cookies.match(/((.*)[$ ])/)
174175
stok_value_2_dirty = res.body.match(/"stok": "(.*?)"/)
175176
stok_value_2 = "#{stok_value_2_dirty}".split('"')[3]
176177
final_cookie = "#{sysauth_value_2}" + 'usernameType_80=admin; stok_80=' + "#{stok_value_2}"

modules/exploits/linux/http/epmp1000_ping_cmd_shell.rb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -127,15 +127,15 @@ def login(user, pass)
127127
}
128128
)
129129

130+
cookies = res.get_cookies
130131
good_response = (
131132
res &&
132133
res.code == 200 &&
133-
res.headers.include?('Set-Cookie') &&
134-
res.headers['Set-Cookie'].include?('sysauth')
134+
cookies.include?('sysauth')
135135
)
136136

137137
if good_response
138-
sysauth_value = res.headers['Set-Cookie'].match(/((.*)[$ ])/)
138+
sysauth_value = cookies.match(/((.*)[$ ])/)
139139

140140
cookie1 = "#{sysauth_value}; " + "globalParams=%7B%22dashboard%22%3A%7B%22refresh_rate%22%3A%225%22%7D%2C%22#{user}%22%3A%7B%22refresh_rate%22%3A%225%22%7D%7D"
141141

@@ -157,21 +157,21 @@ def login(user, pass)
157157
}
158158
)
159159

160+
cookies = res.get_cookies
160161
good_response = (
161162
res &&
162163
res.code == 200 &&
163-
res.headers.include?('Set-Cookie') &&
164-
res.headers['Set-Cookie'].include?('stok=') &&
164+
cookies.include?('stok=') &&
165165
!res.body.include?('Maximum number of users reached.')
166166
)
167167

168168
if good_response
169169
print_good("SUCCESSFUL LOGIN - #{rhost}:#{rport} - #{user.inspect}:#{pass.inspect}")
170170

171171
# get the cookie now
172-
get_stok = res.headers['Set-Cookie'].match(/stok=(.*)/)
172+
get_stok = cookies.match(/stok=(.*)/)
173173
stok_value = get_stok[1]
174-
sysauth_value = res.headers['Set-Cookie'].match(/((.*)[$ ])/)
174+
sysauth_value = cookies.match(/((.*)[$ ])/)
175175
final_cookie = "#{sysauth_value}; " + "globalParams=%7B%22dashboard%22%3A%7B%22refresh_rate%22%3A%225%22%7D%2C%22#{user}%22%3A%7B%22refresh_rate%22%3A%225%22%7D%7D; userType=Installer; usernameType=installer; stok=" + "#{stok_value}"
176176

177177
# create config_uri

0 commit comments

Comments
 (0)