Skip to content

Commit 7c9a65f

Browse files
committed
Merge PR rapid7#1593 - remove msfupdate svn support
2 parents 6e1182b + debae8a commit 7c9a65f

File tree

2 files changed

+23
-12
lines changed

2 files changed

+23
-12
lines changed

msfconsole

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,14 @@ end
3636

3737
def print_deprecation_warning
3838
$stdout.puts ""
39-
$stdout.puts "[*] Deprecation Note: After 2013-03-15 (March 15, 2013), Metasploit"
40-
$stdout.puts "[*] source checkouts will NO LONGER update over SVN, but will be using"
41-
$stdout.puts "[*] GitHub exclusively. You should either download a new Metasploit"
42-
$stdout.puts "[*] installer, or use a git clone of Metasploit Framework before"
43-
$stdout.puts "[*] then. You will also need outbound access to github.com on"
44-
$stdout.puts "[*] TCP port 9418 (git), 22 (ssh) or 443 (https), depending on the"
45-
$stdout.puts "[*] protocol used to clone Metasploit Framework (usually, git protocol)."
39+
$stdout.puts "[-] Deprecation Note: Metasploit source checkouts NO LONGER update"
40+
$stdout.puts "[-] over SVN. You will need to reinstall Metasploit using"
41+
$stdout.puts "[-] binary installers (from http://www.metasploit.com/download ),"
42+
$stdout.puts "[-] Debian packages (currently only supported on Kali Linux), or"
43+
$stdout.puts "[-] a development source checkout from GitHub (see http://r-7.co/ZLhA8P )"
44+
$stdout.puts "[-] "
45+
$stdout.puts "[-] For more on msfupdate and migrating off of SVN, see http://r-7.co/MSF-UP"
46+
$stdout.puts ""
4647
end
4748

4849
if is_svn

msfupdate

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,14 +58,18 @@ end
5858

5959
def print_deprecation_warning
6060
$stdout.puts ""
61-
$stdout.puts "[*] Deprecation Note: After 2013-02-28 (February 28, 2013), Metasploit"
62-
$stdout.puts "[*] source checkouts will NO LONGER update over SVN, but will be using"
63-
$stdout.puts "[*] GitHub exclusively. You should either download a new Metasploit"
64-
$stdout.puts "[*] installer, or use a git clone of Metasploit Framework before"
65-
$stdout.puts "[*] then. You will also need outbound access to github.com:9418/TCP."
61+
$stdout.puts "[-] Deprecation Note: Metasploit source checkouts NO LONGER update"
62+
$stdout.puts "[-] over SVN. You will need to reinstall Metasploit using"
63+
$stdout.puts "[-] binary installers (from http://www.metasploit.com/download ),"
64+
$stdout.puts "[-] Debian packages (currently only supported on Kali Linux), or"
65+
$stdout.puts "[-] a development source checkout from GitHub (see http://r-7.co/ZLhA8P )"
66+
$stdout.puts "[-] "
67+
$stdout.puts "[-] For more on msfupdate and migrating off of SVN, see http://r-7.co/MSF-UP"
6668
$stdout.puts ""
6769
end
6870

71+
# This only exits if you actually pass a wait option, otherwise
72+
# just returns nil. This is likely unexpected, revisit this.
6973
def maybe_wait_and_exit(exit_code=0)
7074
if @actually_wait
7175
$stdout.puts ""
@@ -129,7 +133,13 @@ end
129133

130134
####### Since we're SVN, do it all this way #######
131135
if is_svn
136+
# We're fully deprecated now, so just exit.
137+
# Leaving in the commented code in case someone wants to
138+
# get a last-chance at msfupdate before the SVN server goes
139+
# off line, which will be ANY DAY NOW. Seriously.
132140
print_deprecation_warning
141+
$stdin.readline if @actually_wait
142+
exit(0x11) # Comment this to get old functionality back.
133143
@args.push("--config-dir=#{@configdir}")
134144
@args.push("--non-interactive")
135145

0 commit comments

Comments
 (0)