Death to unicode

Apologies to the authors whose names I am now intentionally misspelling.
Maybe in another 10 years, we can guarantee that all terminals and
machine parsers are okay with unicode suddenly popping up in strings.

Also adds a check in msftidy for stray unicode.

Author: todb

modules/auxiliary/scanner/http/drupal_views_user_enum.rb

@@ -23,7 +23,7 @@ module of Drupal, brute-forcing the first 10 usernames from 'a' to 'z'
 			'Author'         =>
 				[
 					'Justin Klein Keane', #Original Discovery
-					'Robin François <rof[at]navixia.com>'
+					'Robin Francois <rof[at]navixia.com>'
 				],
 			'License'        => MSF_LICENSE,
 			'References'     =>

modules/exploits/multi/http/op5_license.rb

@@ -17,7 +17,7 @@ def initialize(info = {})
 			'Name'        => 'OP5 license.php Remote Command Execution',
 			'Description' => %q{
 				This module exploits an arbitrary root command execution vulnerability in the
-				OP5 Monitor license.php. Ekelöw has confirmed that OP5 Monitor versions 5.3.5,
+				OP5 Monitor license.php. Ekelow has confirmed that OP5 Monitor versions 5.3.5,
 				5.4.0, 5.4.2, 5.5.0, 5.5.1 are vulnerable.
 			},
 			'Author'     => [ 'Peter Osterberg <j[at]vel.nu>' ],
@@ -105,4 +105,4 @@ def exploit
 			return
 		end
 	end
-end
+end

modules/exploits/unix/webapp/trixbox_langchoice.rb

@@ -113,7 +113,7 @@ def check
 		# If it has the target footer, we know its vulnerable
 		# however skining may mean the reverse is not true
 		# We've only tested on v2.6.1, so that is all we will guarantee
-		# Example footer: v2.6.1 ©2008 Fonality
+		# Example footer: v2.6.1 ©2008 Fonality
 #		if response.body =~ /(v2\.(?:[0-5]\.\d|6\.[0-1]))\s{2}©200[0-8] Fonality/
 		if response.body =~ /(v2\.6\.1)\s{2}©2008 Fonality/
 			print_status "Trixbox #{$1} detected!"

modules/exploits/windows/scada/procyon_core_server.rb

@@ -32,7 +32,7 @@ def initialize(info={})
 			'Version'        => '$Revision$',
 			'Author'         =>
 				[
-					'Knud Højgaard <keh[at]nsense.dk>',        # Initial discovery
+					'Knud Hojgaard <keh[at]nsense.dk>',        # Initial discovery
 					'mr_me <steventhomasseeley[at]gmail.com>', # Initial discovery & poc/msf
 				],
 			'References'     =>

tools/msftidy.rb

@@ -3,7 +3,7 @@
 # Check (recursively) for style compliance violations and other
 # tree inconsistencies.
 #
-# by jduck
+# by jduck and friends
 #
 
 ##
@@ -82,6 +82,7 @@ def check_single_file(dparts, fparts, f_rel)
 	spaces = 0
 	bi = []
 	ll = []
+	bc = []
 	cr = 0
 	url_ok = true
 	nbo = 0 # non-bin open
@@ -113,6 +114,9 @@ def check_single_file(dparts, fparts, f_rel)
 		src_ended = true if ln =~ /^__END__$/
 		next if src_ended
 
+		if ln =~ /[\x00-\x08\x0b\x0c\x0e-\x19\x7f-\xff]/
+			bc << [ idx, ln.inspect]
+		end
 
 		if (ln.length > LONG_LINE_LENGTH)
 			ll << [ idx, ln ]
@@ -156,6 +160,14 @@ def check_single_file(dparts, fparts, f_rel)
 		}
 	end
 
+	if bc.length > 0
+		puts "%s ... probably has unicode: %u" % [f, bc.length]
+		bc.each { |ec|
+			ec[1] = ec[1].inspect
+			puts '  %8d: %s' % ec
+		}
+	end
+
 	show_count(f, 'carriage return EOL', cr)
 	show_missing(f, 'incorrect URL to framework site', url_ok)
 	show_missing(f, 'writes to stdout', no_stdio)