Add specs for Msf::HTTP::JBoss::Base

Author: jvazquez-r7

lib/msf/http/jboss/base.rb

@@ -21,11 +21,11 @@ def deploy(opts = {}, num_attempts = 5)
       msg = nil
       if res.nil?
         msg = "Execution failed on #{uri} [No Response]"
-      elsif res.code < 200 || res.code >= 300
-        msg = "http request failed to #{uri} [#{res.code}]"
       elsif res.code == 200
         vprint_status("Successfully called '#{uri}'")
         return res
+      else
+        msg = "http request failed to #{uri} [#{res.code}]"
       end
 
       if attempt < num_attempts - 1

spec/lib/msf/http/jboss/base_spec.rb

@@ -0,0 +1,61 @@
+#-*- coding:binary -*-
+require 'spec_helper'
+
+require 'msf/core'
+require 'msf/http/jboss'
+
+describe Msf::HTTP::JBoss::Base do
+  subject do
+    mod = ::Msf::Exploit.new
+    mod.extend Msf::HTTP::JBoss
+    mod.send(:initialize)
+    mod
+  end
+
+  describe "#deploy" do
+    before :each do
+      allow(subject).to receive(:send_request_cgi) do
+        if res_code.nil?
+          res = nil
+        else
+          res = Rex::Proto::Http::Response.new
+          res.code = res_code
+        end
+
+        res
+      end
+    end
+
+    let (:opts) do
+      {
+        'uri' => '/jmx-console'
+      }
+    end
+
+    it 'returns nil unless uri is provided' do
+      expect(subject.deploy).to be_nil
+    end
+
+    context 'when server timeouts' do
+      let(:res_code) { nil }
+      it { expect(subject.deploy(opts, 1)).to be_nil }
+    end
+
+    context 'when server returns 200' do
+      let(:res_code) { 200 }
+      it { expect(subject.deploy(opts)).to be_kind_of Rex::Proto::Http::Response }
+    end
+
+    context 'when server returns 404' do
+      let(:res_code) { 404 }
+      it { expect(subject.deploy(opts, 1)).to be_kind_of Rex::Proto::Http::Response }
+    end
+  end
+
+  describe "#http_verb" do
+    it "returns POST by default" do
+      expect(subject.http_verb).to eq("POST")
+    end
+  end
+
+end