Skip to content

Commit 7f72eae

Browse files
committed
Comment the one case where we backtick git
There is only the one time we actually need the output of the local git command, so comment it accordingly. Someday, in the unknowable future, we'll use a proper Git library instead of backticks and system() calls.
1 parent 8c9e1ab commit 7f72eae

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

msfupdate

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ end
111111

112112
####### Since we're Git, do it all that way #######
113113
if is_git
114-
out = `git remote show upstream`
114+
out = `git remote show upstream` # Actually need the output for this one.
115115
add_git_upstream unless $?.success? and out =~ %r{(https|git|git@github\.com):(//github\.com/)?(rapid7/metasploit-framework\.git)}
116116

117117
remote = @git_remote || "upstream"

0 commit comments

Comments
 (0)