Improve check

Author: jvazquez-r7

modules/exploits/linux/http/pandora_fms_sqli.rb

@@ -62,27 +62,30 @@ def uri
 
 
   def check
-    # Check version
     vprint_status("#{peer} - Trying to detect installed version")
 
+    version = nil
     res = send_request_cgi({
       'method' => 'GET',
       'uri'    => normalize_uri(uri, 'index.php')
     })
 
-    if res && res.code == 200 && res.body =~ /Pandora FMS - the Flexible Monitoring System/ && res.body =~ /(?<=xx-small;">v)(.*?)(?=<\/td>)/
-      version = $1
-      vprint_status("#{peer} - Pandora FMS version #{version} detected")
-    else
-      vprint_status("#{peer} - Unable to access Pandora FMS")
-      return Exploit::CheckCode::Unknown
+    if res && res.code == 200 && res.body =~ /Pandora FMS - the Flexible Monitoring System/
+      if res.body =~ /<div id="ver_num">v(.*?)<\/div>/
+        version = $1
+      else
+        return Exploit::CheckCode::Detected
+      end
     end
 
-    if version && version <= '4.1.1'
-      return Exploit::CheckCode::Appears
-    else
-      return Exploit::CheckCode::Safe
+    unless version.nil?
+      vprint_status("#{peer} - Pandora FMS #{version} found")
+      if Gem::Version.new(version) <= Gem::Version.new('5.0SP2')
+        return Exploit::CheckCode::Appears
+      end
     end
+
+    Exploit::CheckCode::Safe
   end