Ask the database how long the column should be

Instead of hardcoding a number

Author: egypt

lib/msf/core/db_manager/session.rb

@@ -174,7 +174,7 @@ def create_mdm_session_from_session(opts)
       host = find_or_create_host(h_opts)
       sess_data = {
         datastore: session.exploit_datastore.to_h,
-        desc: session.info,
+        desc: truncate_session_desc(session.info),
         host_id: host.id,
         last_seen: Time.now.utc,
         local_id: session.sid,
@@ -201,11 +201,6 @@ def create_mdm_session_from_session(opts)
         sess_data[:via_exploit] = sess_data[:datastore]['ParentModule']
       end
 
-      # Truncate the session data if necessary
-      if sess_data[:desc]
-        sess_data[:desc] = sess_data[:desc][0,255]
-      end
-
       s = ::Mdm::Session.create!(sess_data)
       s
     }
@@ -218,7 +213,7 @@ def create_mdm_session_from_host(opts)
       sess_data = {
         host_id: host.id,
         stype: opts[:stype],
-        desc: opts[:desc],
+        desc: truncate_session_desc(opts[:desc]),
         platform: opts[:platform],
         via_payload: opts[:via_payload],
         via_exploit: opts[:via_exploit],
@@ -230,13 +225,22 @@ def create_mdm_session_from_host(opts)
         close_reason: opts[:close_reason],
       }
 
-      # Truncate the session data if necessary
-      if sess_data[:desc]
-        sess_data[:desc] = sess_data[:desc][0,255]
-      end
 
       s = ::Mdm::Session.create!(sess_data)
       s
     }
   end
+
+  # Truncate the session data if necessary
+  #
+  # @param desc [String]
+  # @return [String] +desc+ truncated to the max length of the desc column
+  def truncate_session_desc(desc)
+    # Truncate the session data if necessary
+    if desc
+      desc = desc[0, ::Mdm::Session.columns_hash['desc'].limit]
+    end
+    desc
+  end
+
 end