Land rapid7#5474, @wchen-r7 Updates pptpd_chap_secrets to use the new cred API

Author: jvazquez-r7

modules/post/linux/gather/pptpd_chap_secrets.rb

@@ -53,6 +53,34 @@ def load_file(fname)
   end
 
 
+  def report_cred(opts)
+    service_data = {
+      address: opts[:ip],
+      port: opts[:port],
+      service_name: opts[:service_name],
+      protocol: 'tcp',
+      workspace_id: myworkspace_id
+    }
+
+    credential_data = {
+      module_fullname: fullname,
+      post_reference_name: self.refname,
+      session_id: session_db_id,
+      origin_type: :session,
+      private_data: opts[:password],
+      private_type: :password,
+      username: opts[:user]
+    }.merge(service_data)
+
+    login_data = {
+      core: create_credential(credential_data),
+      status: Metasploit::Model::Login::Status::UNTRIED,
+    }.merge(service_data)
+
+    create_credential_login(login_data)
+  end
+
+
   #
   # Extracts client, server, secret, and IP addresses
   #
@@ -77,15 +105,14 @@ def extract_secrets(data)
       secret = (found[2] || '').strip
       ip     = (found[3,found.length] * ", " || '').strip
 
-      report_auth_info({
-        :host   => session.session_host,
-        :port   => 1723, #PPTP port
-        :sname  => 'pptp',
-        :user   => client,
-        :pass   => secret,
-        :type   => 'password',
-        :active => true
-      })
+      report_cred(
+        ip: session.session_host,
+        port: 1723, # PPTP port
+        service_name: 'pptp',
+        user: client,
+        password: secret,
+
+      )
 
       tbl << [client, server, secret, ip]
     end