VISUAL is okay. Also doesn't need to be a path.

I don't believe this opens an untoward attack vector -- if your attacker
can run Metasploit locally, you have much bigger problems.

Author: Tod Beardsley

lib/msf/ui/console/command_dispatcher/core.rb

@@ -107,7 +107,7 @@ def commands
       "connect"  => "Communicate with a host",
       "color"    => "Toggle color",
       "exit"     => "Exit the console",
-      "edit"     => "Edit the current module with $EDITOR",
+      "edit"     => "Edit the current module with $VISUAL or $EDITOR",
       "go_pro"   => "Launch Metasploit web GUI",
       "grep"     => "Grep the output of another command",
       "help"     => "Help menu",
@@ -634,7 +634,7 @@ def local_editor
 
   def cmd_edit_help
     msg = "Edit the currently active module"
-    msg = "#{msg} #{local_editor ? "with #{local_editor}" : "($EDITOR must be set first)"}."
+    msg = "#{msg} #{local_editor ? "with #{local_editor}" : "($VISUAL or $EDITOR must be set first)"}."
     print_line "Usage: edit"
     print_line
     print_line msg
@@ -647,11 +647,7 @@ def cmd_edit_help
   #
   def cmd_edit
     unless local_editor
-      print_error "$EDITOR must be set first. Try 'export EDITOR=/usr/bin/vim'"
-      return
-    end
-    unless ::File.executable_real? local_editor
-      print_error "#{local_editor} doesn't seem to be executable by you."
+      print_error "$VISUAL or $EDITOR must be set first. Try 'export EDITOR=/usr/bin/vim'"
       return
     end
     if active_module