Fix specs for uri_checksum

Author: HD Moore

spec/lib/rex/payloads/meterpreter/uri_checksum_spec.rb

@@ -9,51 +9,22 @@ class DummyClass
   subject(:dummy_object) { DummyClass.new }
 
   it { should respond_to :generate_uri_checksum}
-  it { should respond_to :generate_uri_checksum_with_length}
   it { should respond_to :process_uri_resource}
-
-  describe '#generate_uri_checksum' do
-    let(:checksum_value) { 92 }
-
-    it 'generates a string that checksums back to the original value' do
-      uri_string = dummy_object.generate_uri_checksum(checksum_value)
-      expect(Rex::Text.checksum8(uri_string)).to eq checksum_value
-    end
-
-    context 'when it fails to generate a random URI' do
-      it 'should use the pre-calculated checksum string' do
-        Rex::Text.stub(:checksum8) { false }
-        expect(dummy_object.generate_uri_checksum(checksum_value)).to eq Rex::Payloads::Meterpreter::UriChecksum::URI_CHECKSUM_PRECALC[checksum_value]
-      end
-
-    end
-  end
-
-  describe '#generate_uri_checksum_with_length' do
-    [0, 80, 88, 90, 92, 98, 255, 127].each do |checksum_value|
-      [5,30,50,100,127].each do |uri_length|
-        it "generates a #{uri_length} byte string that checksums back to the original value (#{checksum_value})" do
-          uri_string = dummy_object.generate_uri_checksum_with_length(checksum_value, uri_length)
-          expect(Rex::Text.checksum8(uri_string)).to eq checksum_value
-        end
-      end
-    end
-
-  end
+  it { should respond_to :uri_checksum_lookup}
 
   describe '#process_uri_resource' do
     context 'when passed a value for INITW' do
       let(:uri) { "/7E37v"}
 
       it 'returns a static value of /INITM' do
-        expect(dummy_object.process_uri_resource(uri)).to eq '/INITM'
+        expect(dummy_object.process_uri_resource(uri)[:mode]).to eq :init_native
       end
 
       context 'with junk appended at the end' do
         let(:uri) { "/7E37v_foobar"}
 
         it 'returns a static value of /INITM' do
-          expect(dummy_object.process_uri_resource(uri)).to eq '/INITM'
+          expect(dummy_object.process_uri_resource(uri)[:mode]).to eq nil
         end
       end
     end
@@ -62,14 +33,14 @@ class DummyClass
       let(:uri) { "/a6BF9"}
 
       it 'returns a static value of /INITJM' do
-        expect(dummy_object.process_uri_resource(uri)).to eq '/INITJM'
+        expect(dummy_object.process_uri_resource(uri)[:mode]).to eq :init_java
       end
 
       context 'with junk appended at the end' do
         let(:uri) { "/a6BF9_foobar"}
 
         it 'returns a static value of /INITJM' do
-          expect(dummy_object.process_uri_resource(uri)).to eq '/INITJM'
+          expect(dummy_object.process_uri_resource(uri)[:mode]).to eq nil
         end
       end
     end
@@ -78,14 +49,14 @@ class DummyClass
       let(:uri) { "/39ab3"}
 
       it 'returns /CONN plus random junk' do
-        expect(dummy_object.process_uri_resource(uri)).to match(/\/CONN_(\w){16}/)
+        expect(dummy_object.process_uri_resource(uri)[:mode]).to eq :connect
       end
 
       context 'with junk appended at the end' do
         let(:uri) { "/39ab3_foobar"}
 
         it 'returns /CONN plus the junk' do
-          expect(dummy_object.process_uri_resource(uri)).to eq '/CONN_foobar'
+          expect(dummy_object.process_uri_resource(uri)[:mode]).to eq nil
         end
       end
     end
@@ -94,9 +65,54 @@ class DummyClass
       let(:uri) { "/lolz"}
 
       it 'returns the original uri string' do
-        expect(dummy_object.process_uri_resource(uri)).to eq '/lolz'
+        expect(dummy_object.process_uri_resource(uri)[:mode]).to eq nil
+      end
+    end
+  end
+
+  describe '#generate_uri_checksum' do
+    [0, 80, 88, 90, 92, 98, 255, 127].each do |checksum_value|
+      [5,30,50,100,127].each do |uri_length|
+        ["", "/boom", "/___AAAAAAAAAAAAA"].each do |prefix|
+          it "generates a #{uri_length} byte string that checksums back to the original value (#{checksum_value}) with prefix #{prefix}" do
+            uri_string = dummy_object.generate_uri_checksum(checksum_value, uri_length + prefix.to_s.length, prefix)
+            expect(Rex::Text.checksum8(uri_string)).to eq checksum_value
+          end
+        end
+      end
+    end
+  end
+
+  describe '#uri_checksum_lookup' do
+
+    context 'when passed a value for :connect' do
+      let(:mode) { :connect }
+      it 'returns a URI_CHECKSUM_CONN' do
+        expect(dummy_object.uri_checksum_lookup(mode)).to eq Rex::Payloads::Meterpreter::UriChecksum::URI_CHECKSUM_CONN
       end
     end
+
+    context 'when passed a value for :init_native' do
+      let(:mode) { :init_native }
+      it 'returns a URI_CHECKSUM_INITN' do
+        expect(dummy_object.uri_checksum_lookup(mode)).to eq Rex::Payloads::Meterpreter::UriChecksum::URI_CHECKSUM_INITN
+      end
+    end
+
+    context 'when passed a value for :init_java' do
+      let(:mode) { :init_java }
+      it 'returns a URI_CHECKSUM_INITJ' do
+        expect(dummy_object.uri_checksum_lookup(mode)).to eq Rex::Payloads::Meterpreter::UriChecksum::URI_CHECKSUM_INITJ
+      end
+    end
+
+    context 'when passed a value for :init_python' do
+      let(:mode) { :init_python }
+      it 'returns a URI_CHECKSUM_INITP' do
+        expect(dummy_object.uri_checksum_lookup(mode)).to eq Rex::Payloads::Meterpreter::UriChecksum::URI_CHECKSUM_INITP
+      end
+    end
+
   end
 
 end