Land rapid7#3387, some Set-Cookie msftidy warning fixes

Author: wvu

modules/exploits/multi/http/wikka_spam_exec.rb

@@ -90,8 +90,8 @@ def get_cookie
 
     # Get the cookie in this format:
     # 96522b217a86eca82f6d72ef88c4c7f4=pr5sfcofh5848vnc2sm912ean2; path=/wikka
-    if res and res.headers['Set-Cookie']
-      cookie = res.headers['Set-Cookie'].scan(/(\w+\=\w+); path\=.+$/).flatten[0]
+    if res and !res.get_cookies.empty?
+      cookie = res.get_cookies
     else
       fail_with(Failure::Unknown, "#{peer} - No cookie found, will not continue")
     end
@@ -141,9 +141,10 @@ def login(cookie)
       'vars_post' => login
     })
 
-    if res and res.headers['Set-Cookie'] =~ /user_name/
-      user = res.headers['Set-Cookie'].scan(/(user_name\@\w+=\w+);/)[0] || ""
-      pass = res.headers['Set-Cookie'].scan(/(pass\@\w+=\w+)/)[0] || ""
+    if res and res.get_cookies =~ /user_name/
+      c = res.get_cookies
+      user = c.scan(/(user_name\@\w+=\w+);/)[0] || ""
+      pass = c.scan(/(pass\@\w+=\w+)/)[0] || ""
       cookie_cred = "#{cookie}; #{user}; #{pass}"
     else
       cred = "#{datastore['USERNAME']}:#{datastore['PASSWORD']}"

modules/exploits/multi/http/zabbix_script_exec.rb

@@ -88,7 +88,7 @@ def exploit
       fail_with("Login failed")
     end
 
-    sess = login.headers['Set-Cookie']
+    sess = login.get_cookies
 
     dash = send_request_cgi({
       'method' => 'GET',

modules/exploits/multi/php/php_unserialize_zval_cookie.rb

@@ -255,7 +255,7 @@ def check
     end
 
     # Detect the phpBB cookie name
-    if (res.headers['Set-Cookie'] and res.headers['Set-Cookie'] =~ /(.*)_(sid|data)=/)
+    if res.get_cookies =~ /(.*)_(sid|data)=/
       vprint_status("The server may require a cookie name of '#{$1}_data'")
     end
 

modules/exploits/unix/http/lifesize_room.rb

@@ -56,11 +56,11 @@ def exploit
       'method'    => 'GET',
     }, 10)
 
-    if not (res and res.headers['set-cookie'])
+    if res.nil? || res.get_cookies.empty?
       fail_with(Failure::NotFound, 'Could not obtain a Session ID')
     end
 
-    sessionid = 'PHPSESSID=' << res.headers['set-cookie'].split('PHPSESSID=')[1].split('; ')[0]
+    sessionid = 'PHPSESSID=' << res.get_cookies.split('PHPSESSID=')[1].split('; ')[0]
 
     headers = {
       'Cookie'        => sessionid,

modules/exploits/unix/webapp/foswiki_maketext.rb

@@ -75,7 +75,7 @@ def do_login(username, password)
         }
       })
 
-    if not res or res.code != 302 or res.headers['Set-Cookie'] !~ /FOSWIKISID=([0-9a-f]*)/
+    if not res or res.code != 302 or res.get_cookies !~ /FOSWIKISID=([0-9a-f]*)/
       vprint_status "#{res.code}\n#{res.body}"
       return nil
     end
@@ -102,15 +102,15 @@ def inject_code(session, code)
     vprint_good("validation_key found: #{validation_key}")
 
     if session.empty?
-      if res.headers['Set-Cookie'] =~ /FOSWIKISID=([0-9a-f]*)/
+      if res.get_cookies =~ /FOSWIKISID=([0-9a-f]*)/
         session = $1
       else
         vprint_error("Error using anonymous access")
         return nil
       end
     end
 
-    if res.headers['Set-Cookie'] =~ /FOSWIKISTRIKEONE=([0-9a-f]*)/
+    if res.get_cookies =~ /FOSWIKISTRIKEONE=([0-9a-f]*)/
       strike_one = $1
     else
       vprint_error("Error getting the FOSWIKISTRIKEONE value")

modules/exploits/unix/webapp/hastymail_exec.rb

@@ -103,7 +103,7 @@ def login
     })
 
     if res and res.code == 303
-      @session_id = res["Set-Cookie"]
+      @session_id = res.get_cookies
       print_good "#{peer} - Authentication successful"
     end
   end

modules/exploits/unix/webapp/invision_pboard_unserialize_exec.rb

@@ -75,7 +75,7 @@ def cookie_prefix
         'method' => 'GET'
       })
 
-    if res and res.code == 200 and res.headers['Set-Cookie'] =~ /(.+)session/
+    if res and res.code == 200 and res.get_cookies =~ /(.+)session/
       print_status("#{peer} - Cookie prefix #{$1} found")
       cookie_prefix = $1
     end

modules/exploits/unix/webapp/joomla_media_upload_exec.rb

@@ -177,7 +177,7 @@ def exploit
     print_status("#{peer} - Checking Access to Media Component...")
     res = get_upload_form
 
-    if res and (res.code == 200 or res.code == 302) and res.headers['Set-Cookie'] and res.body =~ /You are not authorised to view this resource/
+    if res and (res.code == 200 or res.code == 302) and !res.get_cookies.empty? and res.body =~ /You are not authorised to view this resource/
       print_status("#{peer} - Authentication required... Proceeding...")
 
       if @username.empty? or @password.empty?
@@ -196,7 +196,7 @@ def exploit
       if not res or res.code != 303
         fail_with(Failure::NoAccess, "#{peer} - Unable to Authenticate")
       end
-    elsif res and (res.code == 200 or res.code == 302) and res.headers['Set-Cookie'] and res.body =~ /<form action="(.*)" id="uploadForm"/
+    elsif res and (res.code == 200 or res.code == 302) and !res.get_cookies.empty? and res.body =~ /<form action="(.*)" id="uploadForm"/
       print_status("#{peer} - Authentication isn't required.... Proceeding...")
       @cookies = res.get_cookies.sub(/;$/, "")
     else

modules/exploits/unix/webapp/nagios_graph_explorer.rb

@@ -79,7 +79,7 @@ def get_login_data
     return '' if !res
 
     nsp = res.body.scan(/<input type='hidden' name='nsp' value='(.+)'>/).flatten[0] || ''
-    cookie = (res.headers['Set-Cookie'] || '').scan(/nagiosxi=(\w+); /).flatten[0]  || ''
+    cookie = res.get_cookies.scan(/nagiosxi=(\w+); /).flatten[0]  || ''
     return nsp, cookie
   end
 

modules/exploits/unix/webapp/openemr_sqli_privesc_upload.rb

@@ -94,7 +94,7 @@ def login(base, name, pass)
         }
     })
 
-    if res && res.code == 200 and res.headers['Set-Cookie'] =~ /OpenEMR=([a-zA-Z0-9]+)/
+    if res && res.code == 200 and res.get_cookies =~ /OpenEMR=([a-zA-Z0-9]+)/
       session = $1
       print_status("#{rhost}:#{rport} - Login successful")
       print_status("#{rhost}:#{rport} - Session cookie is [ #{session} ]")