Skip to content

Commit 9553bfc

Browse files
committed
Merge branch 'remove-rubocop'
2 parents 45490e7 + ee968db commit 9553bfc

File tree

5 files changed

+14
-773
lines changed

5 files changed

+14
-773
lines changed

.rubocop.yml

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
1-
# This list was created by analyzing the last three months (51 modules)
2-
# committed to Metasploit Framework. Many, many older modules will have
3-
# offenses, but this should at least provide a baseline for new modules.
1+
# This list was intially created by analyzing the last three months (51
2+
# modules) committed to Metasploit Framework. Many, many older modules
3+
# will have offenses, but this should at least provide a baseline for
4+
# new modules.
45
#
5-
# Updates to this file should include a 'Description' parameter for
6-
# any explaination needed.
6+
# Updates to this file should include a 'Description' parameter for any
7+
# explaination needed.
78

8-
inherit_from: .rubocop_todo.yml
9+
# inherit_from: .rubocop_todo.yml
910

1011
Style/ClassLength:
1112
Description: 'Most Metasploit modules are quite large. This is ok.'
@@ -42,17 +43,14 @@ Style/NumericLiterals:
4243
Enabled: false
4344
Description: 'This often hurts readability for exploit-ish code.'
4445

45-
Style/PercentLiteralDelimiters:
46+
Style/SpaceInsideBrackets:
4647
Enabled: false
47-
Description: >-
48-
Metasploit devs tend to prefer [] over %w() for
49-
nearly all cases, since we often deal with funny
50-
looking arrays of nonwords. Consistency here is
51-
preferred over element type safety.
48+
Description: 'Until module template are final, most modules will fail this.'
49+
50+
Style/StringLiterals:
51+
Enabled: false
52+
Description: 'Single vs double quote fights are largely unproductive.'
5253

5354
Style/WordArray:
5455
Enabled: false
55-
Description: >-
56-
Metasploit devs have grown comforatble with curly
57-
braces over parens for %w. Disabling this check
58-
prefers consistency.
56+
Description: 'Metasploit prefers consistent use of []'

0 commit comments

Comments
 (0)