Check for sock.get / udp_sock.get issues

Author: HD Moore

tools/msftidy.rb

@@ -529,6 +529,18 @@ def check_newline_eof
     end
   end
 
+  def check_sock_get
+    if @source =~ /\s+sock\.get(\s*|\(|\d+\s*|\d+\s*,\d+\s*)/m && @source !~ /sock\.get_once/
+      info('Please use sock.get_once instead of sock.get')
+    end
+  end
+
+  def check_udp_sock_get
+    if @source =~ /udp_sock\.get[^\d]+/m
+      info('Please specify a timeout to udp_sock.get')
+    end
+  end
+
   private
 
   def load_file(file)
@@ -574,6 +586,8 @@ def run_checks(full_filepath)
   tidy.check_vuln_codes
   tidy.check_vars_get
   tidy.check_newline_eof
+  tidy.check_sock_get
+  tidy.check_udp_sock_get
   return tidy
 end