Skip to content

Commit a584a59

Browse files
committed
Clarify about how BES uses os_flavor
We don't. We don't use os_flavor anymore because it is no longer implemented. We get the information from os_name instead.
1 parent c670bb7 commit a584a59

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

lib/msf/core/exploit/remote/browser_exploit_server.rb

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ module Exploit::Remote::BrowserExploitServer
4848
:ua_name, # Example: MSIE
4949
:ua_ver, # Example: 8.0, 9.0
5050
:os_name, # Example: Windows 7, Linux
51-
:os_flavor, # Example: Home, Enterprise
51+
#:os_flavor, # Example: Home, Enterprise: (currently not implemented in os detection)
5252
:os_device, # Example: iPad, iPhone, etc
5353
:os_vendor, # Example: Microsoft, Ubuntu, Apple, etc
5454
:os_sp, # Example: SP2
@@ -215,14 +215,14 @@ def get_bad_requirements(profile)
215215
# 'cookie_name' =>
216216
# {
217217
# :os_name => 'Windows 7',
218-
# :os_flavor => 'Enterprise',
218+
# :os_flavor => 'Enterprise', # os_flavor is currently not implemented in os detection
219219
# ...... etc ......
220220
# }
221221
# A profile should at least have info about the following:
222222
# :source : The data source. Either from 'script', or 'headers'. The 'script' source
223223
# should be more accurate in some scenarios like browser compatibility mode
224224
# :ua_name : The name of the browser
225-
# :ua_ver : The version of the browser
225+
# :ua_ver : The version of the browser (not yet implemented)
226226
# :os_name : The name of the OS ("Windows XP")
227227
# :os_flavor : The edition of the OS ("Home")
228228
# :language : The system's language
@@ -383,7 +383,6 @@ def get_detection_html(user_agent)
383383
var osInfo = os_detect.getVersion();
384384
var d = {
385385
"os_name" : osInfo.os_name,
386-
"os_flavor" : osInfo.os_flavor,
387386
"os_vendor" : osInfo.os_vendor,
388387
"os_device" : osInfo.os_device,
389388
"ua_name" : osInfo.ua_name,

0 commit comments

Comments
 (0)