Land rapid7#4523: wchen-r7's #inspect->to_s conversions

Keep custom object display behavior the same between Ruby 1.9 and 2.1.

Author: Brent Cook

modules/auxiliary/scanner/http/coldfusion_locale_traversal.rb

@@ -188,7 +188,7 @@ def run_host(ip)
         end
       else
         next if (res.code == 500 or res.code == 404 or res.code == 302)
-        print_error("#{ip} #{res.inspect}")
+        print_error("#{ip} #{res.to_s}")
       end
     end
 

modules/auxiliary/scanner/lotus/lotus_domino_hashes.rb

@@ -59,7 +59,7 @@ def run_host(ip)
 
         else
           print_error("http://#{vhost}:#{rport} - Lotus Domino - Unrecognized #{res.code} response")
-          print_error(res.inspect)
+          print_error(res.to_s)
           return :abort
 
         end

modules/exploits/unix/webapp/oracle_vm_agent_utl.rb

@@ -122,7 +122,7 @@ def go(command)
     end
 
     print_error("Encountered unexpected #{res.code} response:")
-    print_error(res.inspect)
+    print_error(res.to_s)
 
     return nil
   end

modules/exploits/windows/http/easyftp_list.rb

@@ -116,7 +116,7 @@ def exploit
 
     if (res)
       print_error("The server unexpectedly responded, this is not good.")
-      print_status(res.inspect)
+      print_status(res.to_s)
     end
 
     handler

modules/exploits/windows/http/hp_nnm_ovbuildpath_textfile.rb

@@ -237,7 +237,7 @@ def exploit
       print_error("Eek! We weren't expecting a response, but we got one")
       if datastore['DEBUG']
         print_line()
-        print_error(res.inspect)
+        print_error(res.to_s)
       end
     end
 

modules/exploits/windows/http/hp_nnm_ovwebsnmpsrv_uro.rb

@@ -131,7 +131,7 @@ def exploit
 
     if res and res.code != 502
       print_error("Eek! We weren't expecting a response, but we got one")
-      print_status(res.inspect) if datastore['NNM_DEBUG']
+      print_status(res.to_s) if datastore['NNM_DEBUG']
     end
 
     handler

modules/exploits/windows/http/hp_nnm_snmpviewer_actapp.rb

@@ -162,7 +162,7 @@ def exploit
 
     if res and res.code != 502
       print_error("Eek! We weren't expecting a response, but we got one")
-      print_status(res.inspect) if datastore['NNM_DEBUG']
+      print_status(res.to_s) if datastore['NNM_DEBUG']
     end
 
     handler

modules/exploits/windows/http/hp_nnm_webappmon_execvp.rb

@@ -159,7 +159,7 @@ def exploit
       print_error("Eek! We weren't expecting a response, but we got one")
       if datastore['DEBUG']
         print_error('')
-        print_error(res.inspect)
+        print_error(res.to_s)
       end
     end
 

modules/exploits/windows/http/hp_nnm_webappmon_ovjavalocale.rb

@@ -159,7 +159,7 @@ def exploit
       print_error("Eek! We weren't expecting a response, but we got one")
       if datastore['DEBUG']
         print_error('')
-        print_error(res.inspect)
+        print_error(res.to_s)
       end
     end
 

modules/post/windows/gather/credentials/tortoisesvn.rb

@@ -48,7 +48,6 @@ def decrypt_password(data)
       addr = [mem].pack("V")
       len = [data.length].pack("V")
       ret = rg.crypt32.CryptUnprotectData("#{len}#{addr}", 16, nil, nil, nil, 0, 8)
-      #print_status("#{ret.inspect}")
       len, addr = ret["pDataOut"].unpack("V2")
     else
       addr = [mem].pack("Q")