update meterpreter scripts to check the right prerequisites

Author: Brent Cook

scripts/meterpreter/arp_scanner.rb

@@ -102,7 +102,7 @@ def save_found(found_ip)
     save2log = true
   end
 }
-if client.platform =~ /win32|win64/
+if client.platform == 'windows'
   if args.length > 0
     if save2log
       save_found(arp_scan(cidr2scan))

scripts/meterpreter/checkvm.rb

@@ -344,7 +344,7 @@ def qemuchk(session)
 
 end
 
-if client.platform =~ /win32|win64/
+if client.platform == 'windows'
   print_status("Checking if target is a Virtual Machine .....")
   found = hypervchk(session)
   found = vmwarechk(session) if not found

scripts/meterpreter/credcollect.rb

@@ -26,14 +26,9 @@
   end
 }
 
-if client.platform =~ /win32|win64/
+if client.platform == 'windows'
   # Collect even without a database to store them.
-  if client.framework.db.active
-    db_ok = true
-  else
-    db_ok = false
-  end
-
+  db_ok = client.framework.db.active
 
   # Make sure we're rockin Priv and Incognito
   client.core.use("priv") if not client.respond_to?("priv")

scripts/meterpreter/domain_list_gen.rb

@@ -56,7 +56,7 @@ def reg_getvaldata(key,valname)
 # Create Filename info to be appended to downloaded files
 filenameinfo = "_" + ::Time.now.strftime("%Y%m%d.%M%S")
 
-unsupported if client.platform !~ /win32|win64/i
+unsupported if client.platform != 'windows'
 
 # Create a directory for the logs
 logs = ::File.join(Msf::Config.log_directory, 'scripts','domain_admins')

scripts/meterpreter/dumplinks.rb

@@ -369,7 +369,7 @@ def get_time(lo_byte, hi_byte)
   end
   return time
 end
-if client.platform =~ /win32|win64/
+if client.platform == 'windows'
   enum_users(os).each do |user|
     if user['userpath']
       print_status "Extracting lnk files for user #{user['username']} at #{user['userpath']}..."

scripts/meterpreter/duplicate.rb

@@ -84,7 +84,7 @@
   'RunAsJob' => true
 )
 
-if client.platform =~ /win32|win64/
+if client.platform == 'windows'
   server = client.sys.process.open
 
   print_status("Current server process: #{server.name} (#{server.pid})")

scripts/meterpreter/enum_firefox.rb

@@ -254,7 +254,7 @@ def kill_firefox
     kill_frfx = true
   end
 }
-if client.platform =~ /win32|win64/
+if client.platform == 'windows'
   if frfxchk
     user = @client.sys.config.getuid
     if not is_system?

scripts/meterpreter/enum_logged_on_users.rb

@@ -89,7 +89,7 @@ def ls_current
     ls_current
   end
 }
-if client.platform =~ /win32|win64/
+if client.platform == 'windows'
   if args.length == 0
     print_line "Meterpreter Script for enumerating Current logged users and users that have loged in to the system."
     print_line(@@exec_opts.usage)

scripts/meterpreter/enum_powershell_env.rb

@@ -124,7 +124,7 @@ def enum_powershell
 
   end
 end
-if client.platform =~ /win32|win64/
+if client.platform == 'windows'
   enum_powershell
 else
   print_error("This version of Meterpreter is not supported with this Script!")

scripts/meterpreter/enum_putty.rb

@@ -91,7 +91,7 @@ def enum_saved_sessions(reg_key_base)
     end
   end
 end
-if client.platform =~ /win32|win64/
+if client.platform == 'windows'
   hkcu_base.each do |hkb|
     if check_putty(hkb)
       enum_known_ssh_hosts(hkb)