.to_credential now assigns a parent

Metasploit::Credential::Core#to_credential will set the parent to the original core objext
Metasploit::Framework::Credential#to_credential also sets the parent to itself.

Author: darkbushido

app/concerns/metasploit/credential/core/to_credential.rb

@@ -13,7 +13,8 @@ def to_credential
         private:      private.try(:data), 
         private_type: private.try(:type).try(:demodulize).try(:underscore).try(:to_sym), 
         realm:        realm.try(:value), 
-        realm_key:    realm.try(:key) 
+        realm_key:    realm.try(:key),
+        parent:       self
       )
     end
 

lib/metasploit/framework/credential.rb

@@ -87,7 +87,8 @@ def ==(other)
       end
 
       def to_credential
-        self
+        self.parent = self
+        self        
       end
 
       private

lib/metasploit/framework/login_scanner/base.rb

@@ -83,7 +83,6 @@ def each_credential
               # This could be a Credential object, or a Credential Core, or an Attempt object
               # so make sure that whatever it is, we end up with a Credential.
               credential = raw_cred.to_credential
-              credential.parent = raw_cred
 
               if credential.realm.present? && self.class::REALM_KEY.present?
                 credential.realm_key = self.class::REALM_KEY

spec/support/shared/examples/credential/core/to_credential.rb

@@ -16,6 +16,11 @@
         ).to be_a Metasploit::Framework::Credential
       end
 
+      it "should set the parent to the credential object" do
+        expect(
+          crednetial_core.to_credential.parent
+        ).to eq(crednetial_core)
+      end
     end
   end
 end