check for valid values

Author: firefart

tools/msftidy.rb

@@ -545,9 +545,14 @@ def check_lines
         warn("Please use snake case on method names: #{ln}", idx)
       end
 
-      if ln =~ /fail_with\(['"].+['"]\)/
-        error("fail_with requires a Failure:: reason as first parameter: #{ln}", idx)
+      if ln =~ /fail_with\(/
+        if ln =~ /fail_with\(['"].+['"]\)/
+          error("fail_with requires a Failure:: reason as first parameter: #{ln}", idx)
+        elsif ln !~ /fail_with\(Failure\:\:(?:None|Unknown|Unreachable|BadConfig|Disconnected|NotFound|UnexpectedReply|TimeoutExpired|UserInterrupt|NoAccess|NoTarget|NotVulnerable|PayloadFailed),\s*['"].+['"]\)/
+          error("fail_with requires a valid Failure:: reason as first parameter: #{ln}", idx)
+        end
       end
+
     end
   end