Skip to content

Commit b0042f1

Browse files
committed
Undo java serialization and RMI fixes
1 parent 452ebcf commit b0042f1

File tree

5 files changed

+11
-10
lines changed

5 files changed

+11
-10
lines changed

lib/msf/java/jmx/handshake.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ module Handshake
99
# Builds a Rex::Java::Serialization::Model::Stream to make
1010
# a JMX handshake with an endpoint
1111
#
12-
# @param obj_id [String] The endpoint UnicastRef ObjId
12+
# @param id [String] The endpoint UnicastRef ObjId
1313
# @return [Rex::Java::Serialization::Model::Stream]
1414
def handshake_stream(obj_id)
1515
block_data = Rex::Java::Serialization::Model::BlockData.new(nil, "#{obj_id}\xff\xff\xff\xff\xf0\xe0\x74\xea\xad\x0c\xae\xa8")

lib/msf/java/rmi/client.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,8 @@ def recv_return(opts = {})
109109

110110
# Helper method to read fragmented data from a ```Rex::Socket::Tcp```
111111
#
112-
# @param nsock [Rex::Socket::Tcp,#get_once]
113-
# @return [String]
112+
# @param opts [Hash]
113+
# @option opts [Rex::Socket::Tcp] :sock
114114
def safe_get_once(nsock = sock)
115115
data = ''
116116
begin

lib/rex/java/serialization/model/field.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,13 @@ class Field < Element
1111
include Rex::Java::Serialization::Model::Contents
1212

1313
# @!attribute type
14-
# @return [String] The type of the field.
14+
# @return [String] The type of the field.
1515
attr_accessor :type
1616
# @!attribute name
17-
# @return [Rex::Java::Serialization::Model::Utf] The name of the field.
17+
# @return [Rex::Java::Serialization::Model::Utf] The name of the field.
1818
attr_accessor :name
1919
# @!attribute field_type
20-
# @return [Rex::Java::Serialization::Model::Utf] The type of the field on object types.
20+
# @return [Rex::Java::Serialization::Model::Utf] The type of the field on object types.
2121
attr_accessor :field_type
2222

2323
# @param stream [Rex::Java::Serialization::Model::Stream] the stream where it belongs to
@@ -32,7 +32,7 @@ def initialize(stream = nil)
3232
#
3333
# @param io [IO] the io to read from
3434
# @return [self] if deserialization succeeds
35-
# @raise [RuntimeError] if deserialization doesn't succeed
35+
# @faise [RuntimeError] if deserialization doesn't succeed
3636
def decode(io)
3737
code = io.read(1)
3838

lib/rex/java/serialization/model/new_array.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,8 @@ def decode_value(io)
190190

191191
# Serializes an NewArray value
192192
#
193-
# @param value [Fixnum, Float] the value to serialize
193+
# @param value [Fixnum] the value to serialize
194+
# @param value [Float] the value to serialize
194195
# @return [String] the serialized value
195196
# @raise [RuntimeError] if serialization fails
196197
def encode_value(value)

lib/rex/java/serialization/model/stream.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def encode
6363

6464
# Adds an element to the references array
6565
#
66-
# @param ref [Rex::Java::Serialization::Model::Element] the object to save as reference dst
66+
# @param io [Rex::Java::Serialization::Model::Element] the object to save as reference dst
6767
def add_reference(ref)
6868
self.references.push(ref)
6969
end
@@ -120,4 +120,4 @@ def decode_version(io)
120120
end
121121
end
122122
end
123-
end
123+
end

0 commit comments

Comments
 (0)