Fix argument passing for deprecated scripts

This allows the scripts to continue working while warning the user.

See also: c59b5ea.

Author: wvu

lib/msf/base/sessions/scriptable.rb

@@ -53,6 +53,7 @@ def execute_file
 
   #
   # Maps legacy Meterpreter script names to replacement post modules
+  #
   def legacy_script_to_post_module(script_name)
     {
       'autoroute' => 'post/windows/manage/autoroute',
@@ -66,11 +67,11 @@ def legacy_script_to_post_module(script_name)
       'enum_shares' => 'post/windows/gather/enum_shares',
       'file_collector' => 'post/windows/gather/enum_files',
       'get_application_list' => 'post/windows/gather/enum_applications',
-      'getcountermeasure' => 'post/windows/manage/killav',
       'get_filezilla_creds' => 'post/windows/gather/credentials/filezilla_server',
-      'getgui' => 'post/windows/manage/enable_rdp',
       'get_local_subnets' => 'post/windows/manage/autoroute',
       'get_valid_community' => 'post/windows/gather/enum_snmp',
+      'getcountermeasure' => 'post/windows/manage/killav',
+      'getgui' => 'post/windows/manage/enable_rdp',
       'getvncpw' => 'post/windows/gather/credentials/vnc',
       'hashdump' => 'post/windows/gather/smart_hashdump',
       'hostsedit' => 'post/windows/manage/inject_host',
@@ -83,8 +84,8 @@ def legacy_script_to_post_module(script_name)
       'prefetchtool' => 'post/windows/gather/enum_prefetch',
       'remotewinenum' => 'post/windows/gather/wmic_command',
       'schelevator' => 'exploit/windows/local/ms10_092_schelevator',
-      'screenspy' => 'post/windows/gather/screen_spy',
       'screen_unlock' => 'post/windows/escalate/screen_unlock',
+      'screenspy' => 'post/windows/gather/screen_spy',
       'search_dwld' => 'post/windows/gather/enum_files',
       'service_permissions_escalate' => 'exploits/windows/local/service_permissions',
       'uploadexec' => 'post/windows/manage/download_exec',
@@ -101,7 +102,12 @@ def legacy_script_to_post_module(script_name)
   #
   def execute_script(script_name, *args)
     post_module = legacy_script_to_post_module(script_name)
-    script_name = post_module if !post_module.nil?
+
+    if post_module
+      print_warning("Meterpreter scripts are deprecated. Try #{post_module}.")
+      print_warning("Example: run #{post_module} OPTION=value [...]")
+    end
+
     mod = framework.modules.create(script_name)
     if mod
       # Don't report module run events here as it will be taken care of