use correct response filter TLV_TYPE_VALUE_NAME

Brent Cook · Brent Cook · commit b4cf2f5d8c4f · 2015-02-17T08:46:25.000-06:00
diff --git a/lib/msf/core/post/windows/registry.rb b/lib/msf/core/post/windows/registry.rb
@@ -462,6 +462,7 @@ def meterpreter_registry_enumvals(key, view)
       vals.each { |val|
         values <<  val.name
       }
+      return values
     rescue Rex::Post::Meterpreter::RequestError => e
       return nil
     end
diff --git a/lib/rex/post/meterpreter/extensions/stdapi/sys/registry.rb b/lib/rex/post/meterpreter/extensions/stdapi/sys/registry.rb
@@ -344,7 +344,7 @@ def Registry.enum_value_direct(root_key, base_key, perm = KEY_READ)
 
     response = client.send_request(request)
 
-    response.each(TLV_TYPE_KEY_NAME) { |value_name|
+    response.each(TLV_TYPE_VALUE_NAME) { |value_name|
       values << Rex::Post::Meterpreter::Extensions::Stdapi::Sys::RegistrySubsystem::RegistryValue.new(
           client, 0, value_name.value)
     }

Original file line number	Diff line number	Diff line change
`@@ -462,6 +462,7 @@ def meterpreter_registry_enumvals(key, view)`
`462`	`462`	`vals.each { \|val\|`
`463`	`463`	`values << val.name`
`464`	`464`	`}`
	`465`	`+ return values`
`465`	`466`	`rescue Rex::Post::Meterpreter::RequestError => e`
`466`	`467`	`return nil`
`467`	`468`	`end`
Original file line number	Diff line number	Diff line change
`@@ -344,7 +344,7 @@ def Registry.enum_value_direct(root_key, base_key, perm = KEY_READ)`
`344`	`344`
`345`	`345`	`response = client.send_request(request)`
`346`	`346`
`347`		`- response.each(TLV_TYPE_KEY_NAME) { \|value_name\|`
	`347`	`+ response.each(TLV_TYPE_VALUE_NAME) { \|value_name\|`
`348`	`348`	`values << Rex::Post::Meterpreter::Extensions::Stdapi::Sys::RegistrySubsystem::RegistryValue.new(`
`349`	`349`	`client, 0, value_name.value)`
`350`	`350`	`}`