Don't waste instance variables

Author: jvazquez-r7

lib/msf/core/exploit/smb/server/share.rb

@@ -886,7 +886,6 @@ def smb_cmd_trans_find_first2(c, buff)
 
         payload = pkt['Payload'].v['SetupData'].gsub(/\x00/, '').gsub(/.*\\/, '\\').chomp.strip
         file = file_name
-        file_name = Rex::Text.to_unicode(file_name)
         path = Rex::Text.to_unicode(path_name)
 
         dprint("[smb_cmd_trans_find_first2] Payload is: #{payload}")
@@ -927,7 +926,7 @@ def smb_cmd_trans_find_first2(c, buff)
 
         if (payext and payext.downcase.eql?(fileext.downcase)) or payload.length.to_s.eql?('4')
           dprint("[smb_cmd_trans_find_first2] Sending file response #{file}")
-          data = file_name
+          data = Rex::Text.to_unicode(file_name)
           length = [exe_contents.length].pack("V")
           ea = "\x00\x00"
           alloc = "\x00\x00\x10\x00\x00\x00\x00\x00" # Allocation Size = 1048576 || 1Mb
@@ -995,7 +994,6 @@ def smb_cmd_trans_find_first2_file(c, buff)
 
         payload = pkt['Payload'].v['SetupData'].gsub(/\x00/, '').gsub(/.*\\/, '\\').chomp.strip.split('\\').last
         file = file_name
-        file_name = Rex::Text.to_unicode(file_name)
         path = Rex::Text.to_unicode(path_name)
         dprint("[smb_cmd_trans_find_first2_file] Payload is: #{payload}")
         dprint("[smb_cmd_trans_find_first2_file] Payload length: #{payload.length.to_s}")
@@ -1035,7 +1033,7 @@ def smb_cmd_trans_find_first2_file(c, buff)
 
         if (payext and payext.downcase.eql?(fileext.downcase)) or payload.length.to_s.eql?('4')
           dprint("[smb_cmd_trans_find_first2_file] Sending file response #{file}")
-          data = file_name
+          data = Rex::Text.to_unicode(file_name)
         else
           dprint("[smb_cmd_trans_find_first2_file] Sending directory response #{path}")
           data = path
@@ -1083,7 +1081,6 @@ def smb_cmd_trans_find_first2_full(c, buff)
 
         payload = pkt['Payload'].v['SetupData'].gsub(/\x00/, '').gsub(/.*\\/, '\\').chomp.strip
         file = file_name
-        file_name = Rex::Text.to_unicode(file_name)
         path = Rex::Text.to_unicode(path_name)
 
         dprint("[smb_cmd_trans_find_first2_full] Payload is: #{payload}")
@@ -1124,7 +1121,7 @@ def smb_cmd_trans_find_first2_full(c, buff)
 
         if (payext and payext.downcase.eql?(fileext.downcase)) or payload.length.to_s.eql?('4')
           dprint("[smb_cmd_trans_find_first2_full] Sending file response #{file}")
-          data = file_name
+          data = Rex::Text.to_unicode(file_name)
           length = [exe_contents.length].pack("V")
           ea = "\x00\x00"
           alloc = "\x00\x00\x10\x00\x00\x00\x00\x00" # Allocation Size = 1048576 || 1Mb