Land rapid7#3574, has_actions.rb cleanup

Author: wvu

lib/msf/core/module/has_actions.rb

@@ -16,25 +16,23 @@ def initialize(info={})
 
   def action
     sa = datastore['ACTION']
-    return find_action(default_action) if not sa
-    return find_action(sa)
+    sa ? find_action(sa) : find_action(default_action)
   end
 
   def find_action(name)
-    return nil if not name
-    actions.each do |a|
-      return a if a.name == name
+    if name
+      actions.each do |a|
+        return a if a.name == name
+      end
     end
-    return nil
   end
 
   #
   # Returns a boolean indicating whether this module should be run passively
   #
   def passive?
-    act = action()
-    return passive_action?(act.name) if act
-    return self.passive
+    act = action
+    act ? passive_action?(act.name) : self.passive
   end
 
   #