Switch errors over to windows_error gem...

Author: pbarry-r7

Gemfile.lock

@@ -46,6 +46,7 @@ PATH
       sshkey
       tzinfo
       tzinfo-data
+      windows_error
 
 GEM
   remote: https://rubygems.org/
@@ -277,6 +278,7 @@ GEM
       thread_safe (~> 0.1)
     tzinfo-data (1.2016.6)
       tzinfo (>= 1.0.0)
+    windows_error (0.0.2)
     xpath (2.0.0)
       nokogiri (~> 1.3)
     yard (0.9.0)

lib/msf/core/exploit/smb/client/psexec.rb

@@ -1,5 +1,9 @@
 # -*- coding: binary -*-
 require 'rex/proto/dcerpc/svcctl'
+require 'windows_error'
+require 'windows_error/win32'
+
+include WindowsError::Win32
 
 module Msf
 

lib/rex/constants/windows.rb

@@ -10,18 +10,6 @@ module Windows
 
   STANDARD_RIGHTS_REQUIRED = 0x000F0000
 
-  ##
-  #
-  # Errors
-  #
-  ##
-
-  ERROR_SUCCESS = 0x0
-  ERROR_FILE_NOT_FOUND = 0x2
-  ERROR_ACCESS_DENIED = 0x5
-  ERROR_SERVICE_REQUEST_TIMEOUT = 0x41D
-  ERROR_SERVICE_EXISTS = 0x431
-
   ##
   #
   # SVCCTL Protocol Functions

lib/rex/proto/dcerpc/svcctl/packet.rb

@@ -7,12 +7,15 @@ module Rex
 ###
 module Proto::DCERPC::SVCCTL
 
+  require 'windows_error'
+  require 'windows_error/win32'
   require 'rex/constants/windows'
   NDR = Rex::Encoder::NDR
 
 
 class Client
 
+  include WindowsError::Win32
   include Rex::Constants::Windows
 
   attr_accessor :dcerpc_client

metasploit-framework.gemspec

@@ -102,6 +102,8 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'sshkey'
   # BitStruct Library used for handling certain Protocol Header/Packet construction
   spec.add_runtime_dependency 'bit-struct'
+  # Library for interpreting Windows error codes and strings
+  spec.add_runtime_dependency 'windows_error'
 
   #
   # Protocol Libraries