Skip to content

Commit c000e59

Browse files
committed
verified table values are correctly typed as Strs, but it still fails to print the tables
1 parent c2ef7be commit c000e59

File tree

1 file changed

+15
-9
lines changed

1 file changed

+15
-9
lines changed

modules/auxiliary/scanner/misc/dahua_dvr_auth_bypass.rb

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -194,10 +194,10 @@ def grab_channels
194194
print_good("#{peer} -- camera channels:")
195195
data.each_with_index do |val, index|
196196
number = index.to_s
197-
channels = val[/([[:print:]]+)/].to_s
198-
channels_table << [ number, channels ]
199-
channels_table.print
197+
channels = val[/([[:print:]]+)/]
198+
channels_table << [ "#{number}", "#{channels}" ]
200199
end
200+
channels_table.print
201201
end
202202

203203
def grab_users
@@ -216,8 +216,12 @@ def grab_users
216216
usercount += 1
217217
user, md5hash, rights, name = val.match(/^.*:(.*):(.*):.*:(.*):(.*):.*$/).captures
218218
users_table << [user, md5hash, rights, name]
219-
users_table.print
220-
# print_status(" #{val[/(([\d]+)[:]([[:print:]]+))/]}")
219+
# puts user.class
220+
# puts md5hash.class
221+
# puts rights.class
222+
# puts name.class
223+
# users_table.print
224+
print_status(" #{val[/(([\d]+)[:]([[:print:]]+))/]}")
221225
# Write the dahua hash to the database
222226
hash = "#{rhost} #{user}:$dahua$#{md5hash}"
223227
report_hash(rhost, rport, user, hash)
@@ -245,12 +249,14 @@ def grab_groups
245249
'Columns' => ['Number', 'Group']
246250
)
247251
print_good("#{peer} -- groups:")
248-
data.each { |val|
249-
number = val[/(([\d]+))/].to_i
250-
groups = val[/(([a-z]+))/].to_i
252+
data.each do |val|
253+
number = "#{val[/(([\d]+))/]}"
254+
groups = "#{val[/(([a-z]+))/]}"
255+
# puts number.class
256+
# puts groups.class
251257
groups_table << [ number, groups ]
252258
groups_table.print
253-
}
259+
end
254260
end
255261

256262
def reset_user

0 commit comments

Comments
 (0)