Add rudimentary specs and fix some help wording

Author: egypt

lib/msf/ui/console/command_dispatcher/db.rb

@@ -658,22 +658,23 @@ def cmd_creds_help
     print_line "  creds [filter options] [address range]"
     print_line
     print_line "Usage - Adding credentials:"
-    print_line "  creds add-ntlm <user> <password> [domain]"
+    print_line "  creds add-ntlm <user> <ntlm hash> [domain]"
     print_line "  creds add-password <user> <password> [realm]"
-    print_line "  creds add-ssh-key <user> </path/to/id_rsa> [realm]"
+    print_line "  creds add-ssh-key <user> </path/to/id_rsa>"
+    #print_line "Where [realm type] can be one of:"
+    #Metasploit::Model::Realm::Key::SHORT_NAMES.each do |short, description|
+    #  print_line "  #{short} - #{description}"
+    #end
 
     print_line
     print_line "General options"
     print_line "  -h,--help             Show this help information"
     print_line
-    print_line "Filter options"
+    print_line "Filter options for listing"
     print_line "  -P,--password <regex> List passwords that match this regex"
     print_line "  -p,--port <portspec>  List creds with logins on services matching this port spec"
     print_line "  -s <svc names>        List creds matching comma-separated service names"
     print_line "  -u,--user <regex>     List users that match this regex"
-    #print_line
-    #print_line "Add options"
-    #print_line "  --realm-type <type>   One of: domain, db2, sid, pgdb. (Defaults to domain)"
 
     print_line
     print_line "Examples, listing:"
@@ -930,6 +931,8 @@ def cmd_creds_tabs(str, words)
              else
                []
              end
+    #when 5
+    #  tabs = Metasploit::Model::Realm::Key::SHORT_NAMES.keys
     else
       tabs = []
     end

spec/lib/msf/ui/command_dispatcher/db_spec.rb

@@ -11,6 +11,36 @@
     described_class.new(driver)
   end
 
+  describe "#cmd_creds" do
+    describe "add-password" do
+      let(:username) { "username" }
+      let(:password) { "password" }
+      context "when no core exists" do
+        it "should add a Core" do
+          expect {
+            subject.cmd_creds("add-password", username, password)
+          }.to change{ Metasploit::Credential::Core.count }.by 1
+        end
+      end
+      context "when a core already exists" do
+        before(:each) do
+          priv = FactoryGirl.create(:metasploit_credential_password, data: password)
+          pub = FactoryGirl.create(:metasploit_credential_public, username: username)
+          core = FactoryGirl.create(:metasploit_credential_core,
+                                    private: priv,
+                                    public: pub,
+                                    realm: nil,
+                                    workspace: Mdm::Workspace.last)
+        end
+        it "should not add a Core" do
+          expect {
+            subject.cmd_creds("add-password", username, password)
+          }.to_not change{ Metasploit::Credential::Core.count }
+        end
+      end
+    end
+  end
+
   describe "#cmd_workspace" do
     describe "-h" do
       it "should show a help message" do
@@ -183,6 +213,7 @@
 
   end
 
+=begin
   describe "#cmd_creds" do
     describe "-h" do
       it "should show a help message" do
@@ -206,6 +237,7 @@
       end
     end
   end
+=end
 
   describe "#cmd_db_import" do
     describe "-h" do