Fix improper use of host-endian or signed pack/unpack

Note that there are some cases of host-endian left, these
are intentional because they operate on host-local memory
or services.

When in doubt, please use:

```
ri pack
```

Author: HD Moore

lib/bit-struct/octet-field.rb

@@ -37,7 +37,7 @@ def add_accessors_to(cl, attr = name) # :nodoc:
         old_writer = "#{attr_chars}="
 
         define_method "#{attr}=" do |val|
-          data = val.split(sep).map{|s|s.to_i(base)}.pack("c*")
+          data = val.split(sep).map{|s|s.to_i(base)}.pack("C*")
           send(old_writer, data)
         end
       end

lib/msf/core/exploit/afp.rb

@@ -246,8 +246,7 @@ def parse_info_response(response)
   end
 
   def parse_header(packet)
-    header = packet.unpack('CCnNNN') #ruby 1.8.7 don't support unpacking signed integers in big-endian order
-    header[3] = packet[4..7].reverse.unpack("l").first
+    header = packet.unpack('CCnNNN')
     return header
   end
 

lib/msf/core/post/windows/accounts.rb

@@ -270,7 +270,7 @@ def check_dir_perms(dir, token)
 
     #define generic mapping structure
     gen_map = [0,0,0,0]
-    gen_map = gen_map.pack("L")
+    gen_map = gen_map.pack("V")
     buffer_size = 500
 
     #get Security Descriptor for the directory

lib/msf/core/post/windows/ldap.rb

@@ -248,15 +248,15 @@ def query_ldap(session_handle, base, scope, filter, fields)
   # @param pEntry [Fixnum] Pointer to the Entry
   # @return [Array] Entry data structure
   def get_entry(pEntry)
-    return client.railgun.memread(pEntry,41).unpack('LLLLLLLLLSCCC')
+    return client.railgun.memread(pEntry,41).unpack('VVVVVVVVVvCCC')
   end
 
   # Get BER Element data structure from LDAPMessage
   #
   # @param msg [String] The LDAP Message from the server
   # @return [String] The BER data structure
   def get_ber(msg)
-    ber = client.railgun.memread(msg[2],60).unpack('L*')
+    ber = client.railgun.memread(msg[2],60).unpack('V*')
 
     # BER Pointer is different between x86 and x64
     if client.platform =~ /x64/

lib/msf/core/post/windows/services.rb

@@ -334,7 +334,7 @@ def service_status(name, server=nil)
         raise RuntimeError.new("Could not query service. QueryServiceStatus error: #{handle["GetLastError"]}")
       end
 
-      vals = status['lpServiceStatus'].unpack('L*')
+      vals = status['lpServiceStatus'].unpack('V*')
       adv.CloseServiceHandle(handle["return"])
 
       ret = {

lib/msf/util/exe.rb

@@ -654,8 +654,8 @@ def self.replace_msi_buffer(pe, opts)
       msi = fd.read(fd.stat.size)
     }
 
-    section_size =	2**(msi[30..31].unpack('s<')[0])
-    sector_allocation_table = msi[section_size..section_size*2].unpack('l<*')
+    section_size =	2**(msi[30..31].unpack('v')[0])
+    sector_allocation_table = msi[section_size..section_size*2].unpack('V*')
 
     buffer_chain = []
     current_secid = 5	# This is closely coupled with the template provided and ideally

lib/rex/encoder/ndr.rb

@@ -28,7 +28,7 @@ def NDR.short(string)
   # use to encode:
   #       byte element_1;
   def NDR.byte(string)
-    return [string].pack('c')
+    return [string].pack('C')
   end
 
   # Encode a byte array

lib/rex/ole/util.rb

@@ -124,15 +124,15 @@ def self.pack8(value)
 
 
   def self.getUnicodeString(buf)
-    buf = buf.unpack('S*').pack('C*')
+    buf = buf.unpack('v*').pack('C*')
     if (idx = buf.index(0x00.chr))
       buf.slice!(idx, buf.length)
     end
     buf
   end
 
   def self.putUnicodeString(buf)
-    buf = buf.unpack('C*').pack('S*')
+    buf = buf.unpack('C*').pack('v*')
     if (buf.length < 0x40)
       buf << "\x00" * (0x40 - buf.length)
     end

lib/rex/post/meterpreter/extensions/stdapi/railgun/util.rb

@@ -452,9 +452,9 @@ def read_data(type, position, buffer = nil)
       # Both on x86 and x64, DWORD is 32 bits
       return raw.unpack('V').first
     when :BOOL
-      return raw.unpack('l').first == 1
+      return raw.unpack('V').first == 1
     when :LONG
-      return raw.unpack('l').first
+      return raw.unpack('V').first
     end
 
     #If nothing worked thus far, return it raw

lib/rex/proto/dcerpc/ndr.rb

@@ -34,7 +34,7 @@ def self.short(string)
   #       byte element_1;
   def self.byte(string)
     warn 'should be using Rex::Encoder::NDR'
-    return [string].pack('c')
+    return [string].pack('C')
   end
 
   # Encode a byte array