Skip to content

Commit dc0ce88

Browse files
committed
We're note actually using Mubex, it might be causing a crash too
A problem we are seeing is that sometimes when BAP terminates (ie: jobs -K), we hit a deadlock while jobs are trying to cleanup, and sometimes that might cause msfconsole to crash and terminate. We suspect this Mubex is a contributing factor but it has been hard to prove because it's very hard to reproduce the crash.
1 parent 6d30dfd commit dc0ce88

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

lib/msf/core/exploit/remote/browser_exploit_server.rb

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ def setup
108108
if !custom_404.blank? && custom_404 !~ /^http/i
109109
raise Msf::OptionValidateError.new(['Custom404 (must begin with http or https)'])
110110
end
111-
@bes_mutex = Mutex.new
111+
112112
super
113113
end
114114

@@ -144,14 +144,6 @@ def get_custom_404_url
144144
end
145145

146146

147-
# Allows a block of code to access BES resources in a thread-safe fashion
148-
#
149-
# @param block [Proc] Block of code to sync
150-
def sync(&block)
151-
@bes_mutex.synchronize(&block)
152-
end
153-
154-
155147
# Returns the resource (URI) to the module to allow access to on_request_exploit
156148
#
157149
# @return [String] URI to the exploit page

0 commit comments

Comments
 (0)