don't try to guess intent for specified default targets, leave auto-auto targeting to unspecified modules

Author: Brent Cook

lib/msf/core/exploit.rb

@@ -287,14 +287,17 @@ def initialize(info = {})
     # to the information hash.
     super(info)
 
-    self.default_target = info['DefaultTarget'] || 0
-
-    # Add an auto-target to the exploit if it doesn't have one
-    if info['Targets'] && info['Targets'].count > 1 && !has_auto_target?(info['Targets'])
-      # Finally, only add the target if there is a remote host option
-      if self.respond_to?(:rhost) && self.respond_to?(:auto_targeted_index)
-        auto = ["Automatic", {'AutoGenerated' => true}.merge(info['Targets'][self.default_target][1])]
-        info['Targets'].unshift(auto)
+    if info.key? 'DefaultTarget'
+      self.default_target = info['DefaultTarget']
+    else
+      self.default_target = 0
+      # Add an auto-target to the exploit if it doesn't have one
+      if info['Targets'] && info['Targets'].count > 1 && !has_auto_target?(info['Targets'])
+        # Finally, only add the target if there is a remote host option
+        if self.respond_to?(:rhost) && self.respond_to?(:auto_targeted_index)
+          auto = ["Automatic", {'AutoGenerated' => true}.merge(info['Targets'][self.default_target][1])]
+          info['Targets'].unshift(auto)
+        end
       end
     end
 

modules/exploits/linux/misc/quest_pmmasterd_bof.rb

@@ -62,7 +62,7 @@ def initialize(info = {})
         ],
       'Privileged'     => true,
       'DisclosureDate' => 'Apr 09 2017',
-      'DefaultTarget'  => 1
+      'DefaultTarget'  => 0
       )
     )