Avoid explicit use of subject

Author: jvazquez-r7

spec/lib/rex/encoder/alpha2/alpha_mixed_spec.rb

@@ -25,7 +25,7 @@
   end
 
   describe ".gen_decoder_prefix" do
-    subject { described_class.gen_decoder_prefix(reg, offset) }
+    subject(:decoder_prefix) { described_class.gen_decoder_prefix(reg, offset) }
     let(:reg) { 'ECX' }
     let(:offset) { 5 }
 
@@ -38,7 +38,7 @@
       let(:offset) { 0 }
 
       it "raises an error" do
-        expect { subject }.to raise_error(ArgumentError)
+        expect { decoder_prefix }.to raise_error(ArgumentError)
       end
     end
 
@@ -47,14 +47,14 @@
       let(:offset) { 33 }
 
       it "raises an error" do
-        expect { subject }.to raise_error
+        expect { decoder_prefix }.to raise_error
       end
     end
   end
 
 
   describe ".gen_decoder" do
-    subject { described_class.gen_decoder(reg, offset) }
+    subject(:decoder) { described_class.gen_decoder(reg, offset) }
     let(:reg) { 'ECX' }
     let(:offset) { 5 }
 
@@ -71,7 +71,7 @@
       let(:offset) { 0 }
 
       it "raises an error" do
-        expect { subject }.to raise_error(ArgumentError)
+        expect { decoder }.to raise_error(ArgumentError)
       end
     end
 
@@ -80,7 +80,7 @@
       let(:offset) { 33 }
 
       it "raises an error" do
-        expect { subject }.to raise_error
+        expect { decoder }.to raise_error
       end
     end
   end

spec/lib/rex/encoder/alpha2/alpha_upper_spec.rb

@@ -31,7 +31,7 @@
   end
 
   describe ".gen_decoder_prefix" do
-    subject { described_class.gen_decoder_prefix(reg, offset) }
+    subject(:decoder_prefix) { described_class.gen_decoder_prefix(reg, offset) }
     let(:reg) { 'ECX' }
     let(:offset) { 5 }
 
@@ -44,7 +44,7 @@
       let(:offset) { 0 }
 
       it "raises an error" do
-        expect { subject }.to raise_error(ArgumentError)
+        expect { decoder_prefix }.to raise_error(ArgumentError)
       end
     end
 
@@ -53,14 +53,14 @@
       let(:offset) { 25 }
 
       it "raises an error" do
-        expect { subject }.to raise_error
+        expect { decoder_prefix }.to raise_error
       end
     end
   end
 
 
   describe ".gen_decoder" do
-    subject { described_class.gen_decoder(reg, offset) }
+    subject(:decoder) { described_class.gen_decoder(reg, offset) }
     let(:reg) { 'ECX' }
     let(:offset) { 5 }
 
@@ -77,7 +77,7 @@
       let(:offset) { 0 }
 
       it "raises an error" do
-        expect { subject }.to raise_error(ArgumentError)
+        expect { decoder }.to raise_error(ArgumentError)
       end
     end
 
@@ -86,7 +86,7 @@
       let(:offset) { 25 }
 
       it "raises an error" do
-        expect { subject }.to raise_error
+        expect { decoder }.to raise_error
       end
     end
   end

spec/lib/rex/encoder/alpha2/generic_spec.rb

@@ -8,34 +8,34 @@
   it_behaves_like 'Rex::Encoder::Alpha2::Generic'
 
   describe ".default_accepted_chars" do
-    subject { described_class.default_accepted_chars }
+    subject(:accepted_chars) { described_class.default_accepted_chars }
 
     it { is_expected.to eq(('a' .. 'z').to_a + ('B' .. 'Z').to_a + ('0' .. '9').to_a) }
   end
 
   describe ".gen_decoder_prefix" do
-    subject { described_class.gen_decoder_prefix(reg, offset) }
+    subject(:decoder_prefix) { described_class.gen_decoder_prefix(reg, offset) }
     let(:reg) { 'ECX' }
     let(:offset) { 0 }
 
     it { is_expected.to eq('') }
   end
 
   describe ".gen_decoder" do
-    subject { described_class.gen_decoder(reg, offset) }
+    subject(:decoder) { described_class.gen_decoder(reg, offset) }
     let(:reg) { 'ECX' }
     let(:offset) { 0 }
 
     it { is_expected.to eq('') }
   end
 
   describe ".gen_second" do
-    subject { described_class.gen_second(block, base) }
+    subject(:second) { described_class.gen_second(block, base) }
     let(:block) { 0xaf }
     let(:base) { 0xfa }
 
     it "returns block ^ base" do
-      expect(subject ^ base).to eq(block)
+      expect(second ^ base).to eq(block)
     end
   end
 

spec/lib/rex/encoder/alpha2/unicode_mixed_spec.rb

@@ -25,7 +25,7 @@
   end
 
   describe ".gen_decoder_prefix" do
-    subject { described_class.gen_decoder_prefix(reg, offset) }
+    subject(:decoder_prefix) { described_class.gen_decoder_prefix(reg, offset) }
     let(:reg) { 'ECX' }
     let(:offset) { 5 }
 
@@ -38,7 +38,7 @@
       let(:offset) { 0 }
 
       it "raises an error" do
-        expect { subject }.to raise_error(RuntimeError)
+        expect { decoder_prefix }.to raise_error(RuntimeError)
       end
     end
 
@@ -47,14 +47,14 @@
       let(:offset) { 22 }
 
       it "raises an error" do
-        expect { subject }.to raise_error
+        expect { decoder_prefix }.to raise_error
       end
     end
   end
 
 
   describe ".gen_decoder" do
-    subject { described_class.gen_decoder(reg, offset) }
+    subject(:decoder) { described_class.gen_decoder(reg, offset) }
     let(:reg) { 'ECX' }
     let(:offset) { 5 }
 
@@ -71,7 +71,7 @@
       let(:offset) { 0 }
 
       it "raises an error" do
-        expect { subject }.to raise_error(RuntimeError)
+        expect { decoder }.to raise_error(RuntimeError)
       end
     end
 
@@ -80,7 +80,7 @@
       let(:offset) { 22 }
 
       it "raises an error" do
-        expect { subject }.to raise_error
+        expect { decoder }.to raise_error
       end
     end
   end

spec/lib/rex/encoder/alpha2/unicode_upper_spec.rb

@@ -25,13 +25,13 @@
   end
 
   describe ".default_accepted_chars" do
-    subject { described_class.default_accepted_chars }
+    subject(:accepted_chars) { described_class.default_accepted_chars }
 
     it { is_expected.to eq(('B' .. 'Z').to_a + ('0' .. '9').to_a) }
   end
 
   describe ".gen_decoder_prefix" do
-    subject { described_class.gen_decoder_prefix(reg, offset) }
+    subject(:decoder_prefix) { described_class.gen_decoder_prefix(reg, offset) }
     let(:reg) { 'ECX' }
     let(:offset) { 5 }
 
@@ -44,7 +44,7 @@
       let(:offset) { 0 }
 
       it "raises an error" do
-        expect(subject).to be_nil
+        expect(decoder_prefix).to be_nil
       end
     end
 
@@ -53,14 +53,14 @@
       let(:offset) { 7 }
 
       it "raises an error" do
-        expect { subject }.to raise_error(RuntimeError)
+        expect { decoder_prefix }.to raise_error(RuntimeError)
       end
     end
   end
 
 
   describe ".gen_decoder" do
-    subject { described_class.gen_decoder(reg, offset) }
+    subject(:decoder) { described_class.gen_decoder(reg, offset) }
     let(:reg) { 'ECX' }
     let(:offset) { 5 }
 
@@ -77,7 +77,7 @@
       let(:offset) { 0 }
 
       it "raises an error" do
-        expect { subject }.to raise_error(NoMethodError)
+        expect { decoder }.to raise_error(NoMethodError)
       end
     end
 
@@ -86,7 +86,7 @@
       let(:offset) { 7 }
 
       it "raises an error" do
-        expect { subject }.to raise_error(RuntimeError)
+        expect { decoder }.to raise_error(RuntimeError)
       end
     end
   end